[GitHub] [incubator-doris] imay commented on a change in pull request #1861: collect scanner's status when es_http_scan_node close

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #1861: collect scanner's status when es_http_scan_node close
URL: https://github.com/apache/incubator-doris/pull/1861#discussion_r327898810
 
 

 ##########
 File path: be/src/exec/es_http_scan_node.cpp
 ##########
 @@ -266,7 +273,10 @@ Status EsHttpScanNode::close(RuntimeState* state) {
 
     _batch_queue.clear();
 
-    return ExecNode::close(state);
+    RETURN_IF_ERROR(ExecNode::close(state));
+
+    //collect scanners status at last
+    return collect_scanners_status();
 
 Review comment:
   should call this function before ExecNode::close(state)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org