[jira] [Commented] (MAPREDUCE-5491) DFSIO do not initialize write buffer correctly

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14354452#comment-14354452 ] 

Hadoop QA commented on MAPREDUCE-5491:
--------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12602080/MAPREDUCE-5491-v2.patch
  against trunk revision 47f7f18.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient:

                  org.apache.hadoop.mapred.TestMRTimelineEventHandling

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5268//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5268//console

This message is automatically generated.

> DFSIO do not initialize write buffer correctly
> ----------------------------------------------
>
>                 Key: MAPREDUCE-5491
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5491
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: benchmarks, test
>            Reporter: Raymond Liu
>            Assignee: Raymond Liu
>         Attachments: MAPREDUCE-5491-v2.patch, MAPREDUCE-5491.patch
>
>
> In DFSIO test, the IOMapperBase will set bufferSize in configure method, while writeMapper, appendMapper etc use bufferSize to initialize buffer in the constructor. This will lead to buffer not initialized at all. It is ok for non compression route, while compression is used, the output data size will be very small due to all 0 in buffer.
> Thus, the overrided configure method should be be the correct place for initial buffer



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)