You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/03 20:01:32 UTC

[GitHub] [airflow] ashb opened a new pull request #21303: Fix tests for mssql after SQLA 1.4 upgrade

ashb opened a new pull request #21303:
URL: https://github.com/apache/airflow/pull/21303

The way SQLA 1.4 constructed the query then `exeuction_date.in_([])`
changed, and as a result it started failing.

But we don't even need to ask the database in this case, as we know it
won't return any rows.

<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.

Feel free to ping committers for the review!

In case of existing issue, reference it using one of the following:

closes: #ISSUE
related: #ISSUE

How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->

---
**^ Add meaningful description above**

Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb merged pull request #21303: Fix tests for mssql after SQLA 1.4 upgrade

Posted by GitBox <gi...@apache.org>.

ashb merged pull request #21303:
URL: https://github.com/apache/airflow/pull/21303


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on pull request #21303: Fix tests for mssql after SQLA 1.4 upgrade

Posted by GitBox <gi...@apache.org>.

ashb commented on pull request #21303:
URL: https://github.com/apache/airflow/pull/21303#issuecomment-1029368438


   Ha.
   
   Well the mssql passed, but it failed with the dreaded `tests/providers/ssh/operators/test_ssh.py::TestSSHOperator::test_ssh_client_managed_correctly: airflow.exceptions.AirflowException: SSH operator error: Error reading SSH protocol banner`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb edited a comment on pull request #21303: Fix tests for mssql after SQLA 1.4 upgrade

Posted by GitBox <gi...@apache.org>.

ashb edited a comment on pull request #21303:
URL: https://github.com/apache/airflow/pull/21303#issuecomment-1029368438


   Ha.
   
   Well the mssql DB error is gone, but it failed with the dreaded `tests/providers/ssh/operators/test_ssh.py::TestSSHOperator::test_ssh_client_managed_correctly: airflow.exceptions.AirflowException: SSH operator error: Error reading SSH protocol banner`.
   
   Merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on pull request #21303: Fix tests for mssql after SQLA 1.4 upgrade

Posted by GitBox <gi...@apache.org>.

ashb commented on pull request #21303:
URL: https://github.com/apache/airflow/pull/21303#issuecomment-1029351635


   Fingers crossed this should get MSSQL passing now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #21303: Fix tests for mssql after SQLA 1.4 upgrade

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #21303:
URL: https://github.com/apache/airflow/pull/21303#issuecomment-1029368202


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org