[GitHub] [incubator-superset] michellethomas opened a new issue #7393: Chart Options showing up in explore under "Data" tab

[GitBox <gi...@apache.org>]

michellethomas opened a new issue #7393: Chart Options showing up in explore under "Data" tab
URL: https://github.com/apache/incubator-superset/issues/7393
 
 
   In explore the "Chart Options" section is showing up under the `data` tab which looks confusing because it contains controls for the color, legend (things that don't affect the data). The section is moved to the data tab if any of the controls don't have renderTrigger true, the new label_colors control doesn't have renderTrigger set. 
   
   @khtruong Can renderTrigger be set to true for label_colors? Render trigger will make the visualization be re-rendered when the control is changed. If so the "Chart Options" goes back to the Visual tab.
   
   I started to make this change, but noticed that there isn't a control showing up in the UI, it's more of a hidden control, so I'm not sure if it's right to re-render the visualization when the control is changed. If it's a hidden control that can't be set to renderTrigger true, maybe we can put it in the controlSetRow with the other hidden controls (like slice_id, url_params)?
   
   ### Expected results
   
   Chart options section shows up on the "Visual Properties" tab
   
   ### Actual results
   
   Chart options section shows up on the "Data" tab
   
   
   #### How to reproduce the bug
   
   1. Go to a line chart
   2. On the left side panel see "Chart Options"
   
   ### Environment
   
   - superset version: master
   
   ### Checklist
   
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
   - [x] I have reproduced the issue with at least the latest released version of superset.
   - [x] I have checked the issue tracker for the same issue and I haven't found one similar.
   
   @khtruong 
   cc: @graceguo-supercat 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org