[GitHub] [drill] luocooong commented on a diff in pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

[GitBox <gi...@apache.org>]

luocooong commented on code in PR #2610:
URL: https://github.com/apache/drill/pull/2610#discussion_r928797183


##########
exec/vector/pom.xml:
##########
@@ -25,7 +25,7 @@
     <groupId>org.apache.drill.exec</groupId>
     <version>2.0.0-SNAPSHOT</version>
   </parent>
-  <artifactId>vector</artifactId>
+  <artifactId>drill-vector</artifactId>

Review Comment:
   Change is not the best thing without more new things.



##########
pom.xml:
##########
@@ -3965,6 +3977,46 @@
               </exclusion>
             </exclusions>
           </dependency>
+          <dependency>

Review Comment:
   The dependence on Hadoop was tricky. Ensure that the dependency tree does not have a new dependency.



##########
exec/java-exec/src/main/resources/drill-module.conf:
##########
@@ -190,7 +190,9 @@ drill.exec: {
             maximum: 9223372036854775807
         }
     },
-    memory.heap.failure.threshold: 0.85,
+    # Default to failing queries only at 100% heap usage, i.e. the heap usage
+    # limiting logic in the REST API is disabled by default.
+    memory.heap.failure.threshold: 1.0,

Review Comment:
   That's okay.
   In fact, this option is only used for REST modules and it has little effect before Streaming RESTful feature joins because we cannot expect users to send long or short queries.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org