You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/02/22 10:15:28 UTC
[GitHub] [skywalking-rocketbot-ui] taomaree opened a new pull request #430: Suport Relative Path to Deploy to any context path
taomaree opened a new pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] ruibaby edited a comment on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
ruibaby edited a comment on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-803542073
~~It can be configured by env file and built by users, I will submit a pr later.~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] taomaree commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
taomaree commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-809355904
sorry for reply later.
because open more firewall port needs many works to do, so i think there maybe a way to deploy skywalking-ui to any context path, rather than the root.
with this PR, i've deploy skywalking-ui behind nginx, location /skywalking-ui, avoid changing firewall policy.
this PR just woks, and not perfect, becaust it can support web-ui to any context path, but i could not find a way to change "/graph" to "./graph". I would appreciate it if someone tell me how to change /graph to relative path.
if the web-ui's graph path changed, i think the backend needs to change configure like via ```server.servlet.context-path=/some/path/graph```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] dmsolr commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
dmsolr commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-854504007
Have some difference with @ruibaby .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng closed pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
wu-sheng closed pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] taomaree commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
taomaree commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-872119306
@TinyAllen @Fine0830 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] taomaree commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
taomaree commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-868357404
> I am not familiar with the front-end tech stack.
> I prefer to set `server.context-path: /xxx` in `webapp.xml`. (If possible)
> Because I think this way is more general and easier for users.
> WDYT?
sure, but after resolve this issue.
now the front code can only work with root context, not work with any other context.
this PR try to support the front code to deploy to any context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-870711121
> Hi, @taomaree
> I notice the PR does not update after my last comment.
> I mean it not support customized context-path now. (`webapp.yaml` of `oap-webapp` module)
>
> So I want to confirm with you if you want to enhance this feature.(set `server.context-path: /xxxx`)
> If you have no plan or work on other PR, this PR is good to me and I will give an approval now. :)
I think missing configuration in webapp is fine. Does this still work on root as same as current master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] taomaree commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
taomaree commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-870530196
> Hi, @taomaree
> I notice the PR does not update after my last comment.
> I mean it not support customized context-path now. (`webapp.yaml` of `oap-webapp` module)
>
> So I want to confirm with you if you want to enhance this feature.(set `server.context-path: /xxxx`)
> If you have no plan or work on other PR, this PR is good to me and I will give an approval now. :)
it's not include by this front-end project, webapp.yaml is in skywalking project apm-webapp module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-870181949
I have tested the `dev` environment and it is fine. Do you test the `prod` environment work well with this. @dmsolr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] ruibaby commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
ruibaby commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-803544445
I have tested it, this pr is ok. static resources can be requested normally, The graphql link is still under the root path, so I’m not sure what the user’s needs are.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] dmsolr commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
dmsolr commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-870457366
Hi, @taomaree
I notice the PR does not update after my last comment.
I mean it not support customized context-path now. (`webapp.yaml` of `oap-webapp` module)
So I want to confirm with you if you want to enhance this feature.(set `server.context-path: /xxxx`)
If you have no plan or work on other PR, this PR is good to me and I will give an approval now. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] taomaree commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
taomaree commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-855371654
> I have tested it, this pr is ok. static resources can be requested normally, But the graphql link is still under the root path, so I’m not sure what the user’s needs are.
now the graphql link can be requested normally too, and there ware nginx conf sample above .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] ruibaby commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
ruibaby commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-854507038
@dmsolr
> I set the server.context-path: /xxx( server.servlet.context-path: /xxx tried also) in webapp.yaml.
I didn't set that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-861983058
@dmsolr What is the status here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] taomaree commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
taomaree commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-870530196
> Hi, @taomaree
> I notice the PR does not update after my last comment.
> I mean it not support customized context-path now. (`webapp.yaml` of `oap-webapp` module)
>
> So I want to confirm with you if you want to enhance this feature.(set `server.context-path: /xxxx`)
> If you have no plan or work on other PR, this PR is good to me and I will give an approval now. :)
it's not include by this front-end project, webapp.yaml is in skywalking project apm-webapp module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Rwing commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
Rwing commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-861947219
Excuse me, is there any progress on this issue?
And another problem, in docker case, we should allow change the base url in runtime, because it's pure html/js not nodejs in docker image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] taomaree edited a comment on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
taomaree edited a comment on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-870530196
> Hi, @taomaree
> I notice the PR does not update after my last comment.
> I mean it not support customized context-path now. (`webapp.yaml` of `oap-webapp` module)
>
> So I want to confirm with you if you want to enhance this feature.(set `server.context-path: /xxxx`)
> If you have no plan or work on other PR, this PR is good to me and I will give an approval now. :)
it's not include by this front-end project,
webapp.yaml is in skywalking project apm-webapp module.
no plan for more PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] ruibaby edited a comment on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
ruibaby edited a comment on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-803544445
I have tested it, this pr is ok. static resources can be requested normally, But the graphql link is still under the root path, so I’m not sure what the user’s needs are.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-870181949
I have tested the `dev` environment and it is fine. Do you test the `prod` environment work well with this. @dmsolr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] taomaree commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
taomaree commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-868671898
> I got it. Do you have a plan to improve it and then the front-end codes could deploy any context path?
this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] taomaree commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
taomaree commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-869621778
@TinyAllen @Fine0830 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] dmsolr commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
dmsolr commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-867734015
First, work well as you provide nginx configuration sample.
```
upstream skywalking-graphql { server 1.1.1.1:12800;}
server {
listen 80;
location /skywalking-ui {
alias /var/www/html/skywalking-rocketbot-ui/dist;
index index.html index.htm;
try_files $uri $uri/ /index.html;
}
location /skywalking-ui/graphql {
proxy_pass http://skywalking-graphql/graphql;
proxy_redirect off;
}
}
```
Besides this, there are two bad cases below.
1. server.context-path: /xxx （show as my comments)
2. nginx configuration like this.
```
upstream skywalking-graphql { server 1.1.1.1:12800;}
server {
listen 80;
location /skywalking-ui/graphql {
proxy_pass http://skywalking-graphql/graphql;
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] dmsolr commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
dmsolr commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-854501744
@taomaree I have tested this PR, but it is failed.
I set the `server.context-path: /xxx`( server.servlet.context-path: /xxx tried also) in webapp.yaml.
1. the related resource files work as expected. `/xxx/yyy.css`
2. `localhost:8080/xxx` is a blank page. I have not found API `/graphql` called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] dmsolr commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
dmsolr commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-868432857
I got it. Do you have a plan to improve it and then the front-end codes could deploy any context path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-803548352
I am not sure the case either. SkyWalking backend doesn't have an usual case to change this path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-871130401
> > it's not include by this front-end project,
> > webapp.yaml is in skywalking project apm-webapp module.
> > no plan for more PR.
>
> I got it.
> Although the configuration is in `apm-webapp` module, we need to modify the `route.ts` to support that in this repo. :)
> > it's not include by this front-end project,
> > webapp.yaml is in skywalking project apm-webapp module.
> > no plan for more PR.
>
> I got it.
> Although the configuration is in `apm-webapp` module, we need to modify the `route.ts` to support that in this repo. :)
OK, this seems an issue. Could we have a recommended way to support change through webapp?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] taomaree edited a comment on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
taomaree edited a comment on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-809355904
sorry for reply later.
because open more firewall port needs many works to do, so i think there maybe a way to deploy skywalking-ui to any context path, rather than the root.
with this PR, i've deploy skywalking-ui behind nginx, location /skywalking-ui, avoid changing firewall policy.
with reserve proxy like nginx, there is nothing to change of skywalking aop server.
nginx conf sample:
```
upstream skywalking-graphql { server 1.1.1.1:12800;}
server {
listen 80;
location /skywalking-ui {
alias /var/www/html/skywalking-rocketbot-ui/dist;
}
location /skywalking-ui/graphql {
proxy_pass http://skywalking-graphql;
proxy_redirect off;
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-872228464
> @TinyAllen @Fine0830 PTAL
`Could we have a recommended way to support change through webapp?` This has not been answered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] dmsolr commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
dmsolr commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-870457366
Hi, @taomaree
I notice the PR does not update after my last comment.
I mean it not support customized context-path now. (`webapp.yaml` of `oap-webapp` module)
So I want to confirm with you if you want to enhance this feature.(set `server.context-path: /xxxx`)
If you have no plan or work on other PR, this PR is good to me and I will give an approval now. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] taomaree edited a comment on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
taomaree edited a comment on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-809355904
sorry for reply later.
because open more firewall port needs many works to do, so i think there maybe a way to deploy skywalking-ui to any context path, rather than the root.
with this PR, i've deploy skywalking-ui behind nginx, location /skywalking-ui, avoid changing firewall policy.
with reserve proxy like nginx, there is nothing to change of skywalking oap server.
nginx conf sample:
```
upstream skywalking-graphql { server 1.1.1.1:12800;}
server {
listen 80;
location /skywalking-ui {
alias /var/www/html/skywalking-rocketbot-ui/dist;
index index.html index.htm;
try_files $uri $uri/ /index.html;
}
location /skywalking-ui/graphql {
proxy_pass http://skywalking-graphql/graphql;
proxy_redirect off;
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] dmsolr commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
dmsolr commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-868295919
I am not familiar with the front-end tech stack.
I prefer to set `server.context-path: /xxx` in `webapp.xml`. (If possible)
Because I think this way is more general and easier for users.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] taomaree edited a comment on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
taomaree edited a comment on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-809355904
sorry for reply later.
because open more firewall port needs many works to do, so i think there maybe a way to deploy skywalking-ui to any context path, rather than the root.
with this PR, i've deploy skywalking-ui behind nginx, location /skywalking-ui, avoid changing firewall policy.
with reserve proxy like nginx, there is nothing to change of skywalking oap server.
nginx conf sample:
```
upstream skywalking-graphql { server 1.1.1.1:12800;}
server {
listen 80;
location /skywalking-ui {
alias /var/www/html/skywalking-rocketbot-ui/dist;
}
location /skywalking-ui/graphql {
proxy_pass http://skywalking-graphql;
proxy_redirect off;
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] dmsolr commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
dmsolr commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-867414855
I am so sorry about missing the message.
Looks good to me. But I would like to do a full test in the local env.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] dmsolr commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
dmsolr commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-871085473
> > Hi, @taomaree
> > I notice the PR does not update after my last comment.
> > I mean it not support customized context-path now. (`webapp.yaml` of `oap-webapp` module)
> > So I want to confirm with you if you want to enhance this feature.(set `server.context-path: /xxxx`)
> > If you have no plan or work on other PR, this PR is good to me and I will give an approval now. :)
>
> I think missing configuration in webapp is fine. Does this still work on root as same as current master?
Yes, it does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-783357812
I am not sure whether this works? How is a `./` helping?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-1053203096
Rocketbot UI is replaced by the new [Booster UI](https://github.com/apache/skywalking-booster-ui) since 9.0.0 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] taomaree commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
taomaree commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-868213404
> https://github.com/apache/skywalking-rocketbot-ui/blob/59b701e528f8b984d12c5fc5c2656c37c7a8129f/src/router.ts#L33
>
> Seem `path` **MUST** be hard code?
vuejs docs https://cli.vuejs.org/config/#publicpath
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] taomaree edited a comment on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
taomaree edited a comment on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-809355904
sorry for reply later.
because open more firewall port needs many works to do, so i think there maybe a way to deploy skywalking-ui to any context path, rather than the root.
with this PR, i've deploy skywalking-ui behind nginx, location /skywalking-ui, avoid changing firewall policy.
nginx conf sample:
```
upstream skywalking-graphql { server 1.1.1.1:12800;}
server {
listen 80;
location /skywalking-ui {
alias /var/www/html/skywalking-rocketbot-ui/dist;
}
location /skywalking-ui/graphql {
proxy_pass http://skywalking-graphql;
proxy_redirect off;
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] dmsolr commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
dmsolr commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-871085351
> it's not include by this front-end project,
> webapp.yaml is in skywalking project apm-webapp module.
> no plan for more PR.
I got it.
Although the configuration is in `apm-webapp` module, we need to modify the `route.ts` to support that in this repo. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] taomaree edited a comment on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
taomaree edited a comment on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-870530196
> Hi, @taomaree
> I notice the PR does not update after my last comment.
> I mean it not support customized context-path now. (`webapp.yaml` of `oap-webapp` module)
>
> So I want to confirm with you if you want to enhance this feature.(set `server.context-path: /xxxx`)
> If you have no plan or work on other PR, this PR is good to me and I will give an approval now. :)
it's not include by this front-end project,
webapp.yaml is in skywalking project apm-webapp module.
no plan for more PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] ruibaby commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
ruibaby commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-803542073
It can be configured by env file and built by users, I will submit a pr later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] dmsolr commented on pull request #430: Suport Relative Path to Deploy to any context path
Posted by GitBox <gi...@apache.org>.
dmsolr commented on pull request #430:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/430#issuecomment-867825041
https://github.com/apache/skywalking-rocketbot-ui/blob/59b701e528f8b984d12c5fc5c2656c37c7a8129f/src/router.ts#L33
Seem `path` **MUST** be hard code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org