[jira] [Commented] (MSHARED-864) Refactor and simplify code

["Karl Heinz Marbaise (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MSHARED-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17075207#comment-17075207 ] 

Karl Heinz Marbaise commented on MSHARED-864:
---------------------------------------------

Done in [9a5c5f30eda95beef4faefe26ca8c0aa985092d0|https://gitbox.apache.org/repos/asf?p=maven-artifact-transfer.git;a=commitdiff;h=9a5c5f30eda95beef4faefe26ca8c0aa985092d0]

> Refactor and simplify code
> --------------------------
>
>                 Key: MSHARED-864
>                 URL: https://issues.apache.org/jira/browse/MSHARED-864
>             Project: Maven Shared Components
>          Issue Type: Improvement
>          Components: maven-artifact-transfer
>    Affects Versions: maven-artifact-transfer-0.13.0
>            Reporter: Karl Heinz Marbaise
>            Assignee: Karl Heinz Marbaise
>            Priority: Minor
>             Fix For: maven-artifact-transfer-0.13.0
>
>
> * In the classes {{Maven30DependencyResolver.java}}, {{Maven31DependencyResolver.java}} code can be cleaned up.
> ** The code calls {{setDependencies( List<Dependency> dependencies )}} of {{CollectRequest}} which allows to give {{null}}
> * Refactoring in {{Invoker.java}}
> ** Remove not used methods.
> ** Inlining only locally called methods.
> ** Move the SuppressWarnings to the invoke methods only; Not in user code (outside of Invoker classes)
> ** Make code comment requirements to code requirements (number of elements in {{argClasses}} ands {{args}})
> ** Using generics removes the need of type casts in user code (outside Invoker classes)
> * Simplify catching exceptions (
> * {{MavenArtifactDeployer}} interface is not needed to be public.
> * {{MavenDependencyCollector}} interface is not needed to be public.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)