You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/05 17:27:53 UTC

[GitHub] [superset] diegomedina248 commented on a diff in pull request #19430: fix(data-upload): make to change err message

diegomedina248 commented on code in PR #19430:
URL: https://github.com/apache/superset/pull/19430#discussion_r843089165


##########
superset/views/core.py:
##########
@@ -2810,7 +2810,7 @@ def schemas_access_for_file_upload(self) -> FlaskResponse:
         get the schema access control settings for file upload in this database
         """
         if not request.args.get("db_id"):
-            return json_error_response("No database is allowed for your csv upload")
+            return json_error_response("No database is allowed for your file upload")

Review Comment:
   yeah, and to me this is fine, but since the message now is more generic, I just want to be sure there's no problem with it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org