You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "HouSong (via GitHub)" <gi...@apache.org> on 2024/05/10 05:45:59 UTC

[PR] when use list as out property in sql tasks, if sql result has only one row, still wrap result in a list [dolphinscheduler]

HouSong opened a new pull request, #15972:
URL: https://github.com/apache/dolphinscheduler/pull/15972

   
   <!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! -->
   
   ## Purpose of the pull request
   
   
   when use list as out property in sql tasks, if sql result has only one row, there will be an exception. 
   In this PR, when use list as out property in sql tasks, if sql result has only one row, this result will be wrapped in a list; if sql result has no row, use property value as default and wrap it in a list (if property value exists) .
   
   ## Brief change log
   
   <!--*(for example:)*
   - *Add maven-checkstyle-plugin to root pom.xml*
   -->
   
   ## Verify this pull request
   
   <!--*(Please pick either of the following options)*-->
   
   This pull request is code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   <!--*(example:)*
   - *Added dolphinscheduler-dao tests for end-to-end.*
   - *Added CronUtilsTest to verify the change.*
   - *Manually verified the change by testing locally.* -->
   
   (or)
   
   If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] when use list as out property in sql tasks, if sql result has only one row, still wrap result in a list [dolphinscheduler]

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15972:
URL: https://github.com/apache/dolphinscheduler/pull/15972#issuecomment-2105741798

   ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15972) **Quality Gate failed**  
   Failed conditions  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png '') [39.9% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15972&metric=new_coverage&view=list) (required ≥ 60%)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png '') [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15972) (required ≥ A)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png '') [E Security Rating on New Code](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15972) (required ≥ A)  
     
   [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15972)
   
   ##   
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png '') Catch issues before they fail your Quality Gate with our IDE extension ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png '') [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] when use list as out property in sql tasks, if sql result has only one row, still wrap result in a list [dolphinscheduler]

Posted by "HouSong (via GitHub)" <gi...@apache.org>.
HouSong commented on PR #15972:
URL: https://github.com/apache/dolphinscheduler/pull/15972#issuecomment-2104205241

   > Please change your target branch to `dev` and link this PR to your issue.
   
   I haven't created an issue for this PR. Is it required? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] when use list as out property in sql tasks, if sql result has only one row, still wrap result in a list [dolphinscheduler]

Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on PR #15972:
URL: https://github.com/apache/dolphinscheduler/pull/15972#issuecomment-2104419130

   Please rebase dev.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] when use list as out property in sql tasks, if sql result has only one row, still wrap result in a list [dolphinscheduler]

Posted by "wangxj3 (via GitHub)" <gi...@apache.org>.
wangxj3 commented on PR #15972:
URL: https://github.com/apache/dolphinscheduler/pull/15972#issuecomment-2107350002

   There seems to be some conflict, please pull the upstream dev code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] when use list as out property in sql tasks, if sql result has only one row, still wrap result in a list [dolphinscheduler]

Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS closed pull request #15972: when use list as out property in sql tasks, if sql result has only one row, still wrap result in a list
URL: https://github.com/apache/dolphinscheduler/pull/15972


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] when use list as out property in sql tasks, if sql result has only one row, still wrap result in a list [dolphinscheduler]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #15972:
URL: https://github.com/apache/dolphinscheduler/pull/15972#issuecomment-2105740005

   ## [Codecov](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15972?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   Attention: Patch coverage is `36.40000%` with `318 lines` in your changes are missing coverage. Please review.
   > Project coverage is 38.43%. Comparing base [(`3640a28`)](https://app.codecov.io/gh/apache/dolphinscheduler/commit/3640a2834848765f796ed1b6ba5e832657069332?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`2c65c17`)](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15972?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 141 commits behind head on dev.
   
   > :exclamation: Current head 2c65c17 differs from pull request most recent head 9ee0b1e. Consider uploading reports for the commit 9ee0b1e to get more accurate results
   
   | [Files](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15972?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [.../master/runner/taskgroup/TaskGroupCoordinator.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15972?src=pr&el=tree&filepath=dolphinscheduler-master%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fdolphinscheduler%2Fserver%2Fmaster%2Frunner%2Ftaskgroup%2FTaskGroupCoordinator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvdGFza2dyb3VwL1Rhc2tHcm91cENvb3JkaW5hdG9yLmphdmE=) | 42.10% | [114 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...duler/plugin/datasource/api/utils/CommonUtils.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15972?src=pr&el=tree&filepath=dolphinscheduler-datasource-plugin%2Fdolphinscheduler-datasource-api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fdolphinscheduler%2Fplugin%2Fdatasource%2Fapi%2Futils%2FCommonUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1kYXRhc291cmNlLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLWRhdGFzb3VyY2UtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3BsdWdpbi9kYXRhc291cmNlL2FwaS91dGlscy9Db21tb25VdGlscy5qYXZh) | 5.12% | [37 Missing :warning: ](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../server/master/runner/WorkflowExecuteRunnable.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15972?src=pr&el=tree&filepath=dolphinscheduler-master%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fdolphinscheduler%2Fserver%2Fmaster%2Frunner%2FWorkflowExecuteRunnable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvV29ya2Zsb3dFeGVjdXRlUnVubmFibGUuamF2YQ==) | 3.70% | [24 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...pache/dolphinscheduler/common/utils/FileUtils.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15972?src=pr&el=tree&filepath=dolphinscheduler-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fdolphinscheduler%2Fcommon%2Futils%2FFileUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0ZpbGVVdGlscy5qYXZh) | 22.22% | [18 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...aster/rpc/TaskInstanceWakeupOperationFunction.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15972?src=pr&el=tree&filepath=dolphinscheduler-master%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fdolphinscheduler%2Fserver%2Fmaster%2Frpc%2FTaskInstanceWakeupOperationFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ycGMvVGFza0luc3RhbmNlV2FrZXVwT3BlcmF0aW9uRnVuY3Rpb24uamF2YQ==) | 0.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...cheduler/api/service/impl/ExecutorServiceImpl.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15972?src=pr&el=tree&filepath=dolphinscheduler-api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fdolphinscheduler%2Fapi%2Fservice%2Fimpl%2FExecutorServiceImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9FeGVjdXRvclNlcnZpY2VJbXBsLmphdmE=) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...nscheduler/service/process/ProcessServiceImpl.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15972?src=pr&el=tree&filepath=dolphinscheduler-service%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fdolphinscheduler%2Fservice%2Fprocess%2FProcessServiceImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvcHJvY2Vzcy9Qcm9jZXNzU2VydmljZUltcGwuamF2YQ==) | 56.00% | [8 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...tasource/mysql/param/MySQLDataSourceProcessor.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15972?src=pr&el=tree&filepath=dolphinscheduler-datasource-plugin%2Fdolphinscheduler-datasource-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fdolphinscheduler%2Fplugin%2Fdatasource%2Fmysql%2Fparam%2FMySQLDataSourceProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1kYXRhc291cmNlLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLWRhdGFzb3VyY2UtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcGx1Z2luL2RhdGFzb3VyY2UvbXlzcWwvcGFyYW0vTXlTUUxEYXRhU291cmNlUHJvY2Vzc29yLmphdmE=) | 0.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ver/master/runner/TaskExecutionContextFactory.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15972?src=pr&el=tree&filepath=dolphinscheduler-master%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fdolphinscheduler%2Fserver%2Fmaster%2Frunner%2FTaskExecutionContextFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvVGFza0V4ZWN1dGlvbkNvbnRleHRGYWN0b3J5LmphdmE=) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...uler/plugin/task/api/parameters/SqlParameters.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15972?src=pr&el=tree&filepath=dolphinscheduler-task-plugin%2Fdolphinscheduler-task-api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fdolphinscheduler%2Fplugin%2Ftask%2Fapi%2Fparameters%2FSqlParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci10YXNrLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLXRhc2stYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3BsdWdpbi90YXNrL2FwaS9wYXJhbWV0ZXJzL1NxbFBhcmFtZXRlcnMuamF2YQ==) | 20.00% | [5 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [27 more](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15972?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev   #15972      +/-   ##
   ============================================
   + Coverage     38.15%   38.43%   +0.28%     
   - Complexity     4707     4735      +28     
   ============================================
     Files          1304     1301       -3     
     Lines         44828    44745      -83     
     Branches       4807     4786      -21     
   ============================================
   + Hits          17105    17199      +94     
   + Misses        25870    25665     -205     
   - Partials       1853     1881      +28     
   ```
   
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15972?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] when use list as out property in sql tasks, if sql result has only one row, still wrap result in a list [dolphinscheduler]

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15972:
URL: https://github.com/apache/dolphinscheduler/pull/15972#issuecomment-2105741804

   Please retry analysis of this Pull-Request directly on SonarCloud


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org