You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/14 15:24:39 UTC

[GitHub] [incubator-superset] geido commented on a change in pull request #12038: fix: Closes #11864 - Duplicate PropertiesModal

geido commented on a change in pull request #12038:
URL: https://github.com/apache/incubator-superset/pull/12038#discussion_r542470505



##########
File path: superset-frontend/src/explore/components/ExploreChartHeader.jsx
##########
@@ -202,7 +202,10 @@ export class ExploreChartHeader extends React.PureComponent {
             status={CHART_STATUS_MAP[chartStatus]}
           />
           <ExploreActionButtons
-            actions={this.props.actions}
+            actions={{
+              ...this.props.actions,
+              openPropertiesModal: this.openProperiesModal,

Review comment:
       Yeah, that was there already, but let me fix it. I also hate typos :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org