You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/12/02 08:38:36 UTC
[GitHub] [incubator-doris] kezhenxu94 opened a new pull request #7280: Add third-party GitHub Action as submodule to allow it to run
kezhenxu94 opened a new pull request #7280:
URL: https://github.com/apache/incubator-doris/pull/7280
## Proposed changes
Add the 3rd-party GHA as submodule so that it can be run without asking to add it into allow list.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [ ] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [x] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
Related https://issues.apache.org/jira/browse/INFRA-22554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #7280: Add third-party GitHub Action as submodule to allow it to run
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #7280:
URL: https://github.com/apache/incubator-doris/pull/7280#issuecomment-984444993
> Hi, @morningman the workflow is now executed but there are a lot of code styles issues, do you want to merge this first and then you deal with the code styles in another PR, or do you want to deal with the code styles in this PR?
That's great! Thanks for your help!
Yes the code style has a lot issues, we will handle it in future, it doesn't matter!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #7280: Add third-party GitHub Action as submodule to allow it to run
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #7280:
URL: https://github.com/apache/incubator-doris/pull/7280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7280: Add third-party GitHub Action as submodule to allow it to run
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7280:
URL: https://github.com/apache/incubator-doris/pull/7280#issuecomment-984447060
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kezhenxu94 edited a comment on pull request #7280: Add third-party GitHub Action as submodule to allow it to run
Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on pull request #7280:
URL: https://github.com/apache/incubator-doris/pull/7280#issuecomment-984411109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kezhenxu94 commented on pull request #7280: Add third-party GitHub Action as submodule to allow it to run
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #7280:
URL: https://github.com/apache/incubator-doris/pull/7280#issuecomment-984411109
Hi, @morningman the workflow is now executed but there are a lot of code styles, do you want to merge this first and then you deal with the code styles, or do you want to deal with the code styles in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org