You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Kanna Karanam (JIRA)" <ji...@apache.org> on 2012/07/30 19:53:33 UTC
[jira] [Created] (HIVE-3320) Handle “CRLF” line endings to avoid the extra spacing in generated test outputs in Windows. (Utilities.Java :: readColumn)
Kanna Karanam created HIVE-3320:
-----------------------------------
Summary: Handle “CRLF” line endings to avoid the extra spacing in generated test outputs in Windows. (Utilities.Java :: readColumn)
Key: HIVE-3320
URL: https://issues.apache.org/jira/browse/HIVE-3320
Project: Hive
Issue Type: Sub-task
Components: CLI, Tests, Windows
Reporter: Kanna Karanam
Assignee: Kanna Karanam
Existing functionality in Hive is looking for the “LF” character to extract the lines from generated output before writing to the streaming object. Whereas in Windows, the line endings are “CRLF” characters so it is leaving the “CR” character before writing each line to the streaming object. This CR is introducing the extra empty lines in the generated test output and causing several test cases to fail on Windows.
Attached the generated output for one of the unit test failures with extra space. (bucket1.q)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3320) Handle “CRLF” line endings to avoid the extra spacing in generated test outputs in Windows. (Utilities.Java :: readColumn)
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-3320:
-----------------------------------
Status: Patch Available (was: Open)
> Handle “CRLF” line endings to avoid the extra spacing in generated test outputs in Windows. (Utilities.Java :: readColumn)
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3320
> URL: https://issues.apache.org/jira/browse/HIVE-3320
> Project: Hive
> Issue Type: Sub-task
> Components: CLI, Tests, Windows
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows
> Attachments: HIVE-3320.1.patch.txt, bucket1.q.out.patch.txt
>
>
> Existing functionality in Hive is looking for the “LF” character to extract the lines from generated output before writing to the streaming object. Whereas in Windows, the line endings are “CRLF” characters so it is leaving the “CR” character before writing each line to the streaming object. This CR is introducing the extra empty lines in the generated test output and causing several test cases to fail on Windows.
> Attached the generated output for one of the unit test failures with extra space. (bucket1.q)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3320) Handle “CRLF” line endings to avoid the extra spacing in generated test outputs in Windows. (Utilities.Java :: readColumn)
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427825#comment-13427825 ]
Hudson commented on HIVE-3320:
------------------------------
Integrated in Hive-trunk-h0.21 #1588 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1588/])
HIVE-3320 : Handle CRLF line endings to avoid the extra spacing in generated test outputs in Windows. (Utilities.Java :: readColumn) (Kanna Karanam via Ashutosh Chauhan) (Revision 1368624)
Result = FAILURE
hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1368624
Files :
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
> Handle “CRLF” line endings to avoid the extra spacing in generated test outputs in Windows. (Utilities.Java :: readColumn)
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3320
> URL: https://issues.apache.org/jira/browse/HIVE-3320
> Project: Hive
> Issue Type: Sub-task
> Components: CLI, Tests, Windows
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows
> Fix For: 0.10.0
>
> Attachments: HIVE-3320.1.patch.txt, bucket1.q.out.patch.txt
>
>
> Existing functionality in Hive is looking for the “LF” character to extract the lines from generated output before writing to the streaming object. Whereas in Windows, the line endings are “CRLF” characters so it is leaving the “CR” character before writing each line to the streaming object. This CR is introducing the extra empty lines in the generated test output and causing several test cases to fail on Windows.
> Attached the generated output for one of the unit test failures with extra space. (bucket1.q)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3320) Handle “CRLF” line endings to avoid the extra spacing in generated test outputs in Windows. (Utilities.Java :: readColumn)
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kanna Karanam updated HIVE-3320:
--------------------------------
Attachment: bucket1.q.out.patch.txt
Attached the sample output file for one of the test failures.
> Handle “CRLF” line endings to avoid the extra spacing in generated test outputs in Windows. (Utilities.Java :: readColumn)
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3320
> URL: https://issues.apache.org/jira/browse/HIVE-3320
> Project: Hive
> Issue Type: Sub-task
> Components: CLI, Tests, Windows
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows
> Attachments: bucket1.q.out.patch.txt
>
>
> Existing functionality in Hive is looking for the “LF” character to extract the lines from generated output before writing to the streaming object. Whereas in Windows, the line endings are “CRLF” characters so it is leaving the “CR” character before writing each line to the streaming object. This CR is introducing the extra empty lines in the generated test output and causing several test cases to fail on Windows.
> Attached the generated output for one of the unit test failures with extra space. (bucket1.q)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3320) Handle “CRLF” line endings to avoid the extra spacing in generated test outputs in Windows. (Utilities.Java :: readColumn)
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427113#comment-13427113 ]
Ashutosh Chauhan commented on HIVE-3320:
----------------------------------------
+1 Running tests.
> Handle “CRLF” line endings to avoid the extra spacing in generated test outputs in Windows. (Utilities.Java :: readColumn)
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3320
> URL: https://issues.apache.org/jira/browse/HIVE-3320
> Project: Hive
> Issue Type: Sub-task
> Components: CLI, Tests, Windows
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows
> Attachments: HIVE-3320.1.patch.txt, bucket1.q.out.patch.txt
>
>
> Existing functionality in Hive is looking for the “LF” character to extract the lines from generated output before writing to the streaming object. Whereas in Windows, the line endings are “CRLF” characters so it is leaving the “CR” character before writing each line to the streaming object. This CR is introducing the extra empty lines in the generated test output and causing several test cases to fail on Windows.
> Attached the generated output for one of the unit test failures with extra space. (bucket1.q)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3320) Handle “CRLF” line endings to avoid the extra spacing in generated test outputs in Windows. (Utilities.Java :: readColumn)
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-3320:
-----------------------------------
Resolution: Fixed
Fix Version/s: 0.10.0
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks, Kanna!
> Handle “CRLF” line endings to avoid the extra spacing in generated test outputs in Windows. (Utilities.Java :: readColumn)
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3320
> URL: https://issues.apache.org/jira/browse/HIVE-3320
> Project: Hive
> Issue Type: Sub-task
> Components: CLI, Tests, Windows
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows
> Fix For: 0.10.0
>
> Attachments: HIVE-3320.1.patch.txt, bucket1.q.out.patch.txt
>
>
> Existing functionality in Hive is looking for the “LF” character to extract the lines from generated output before writing to the streaming object. Whereas in Windows, the line endings are “CRLF” characters so it is leaving the “CR” character before writing each line to the streaming object. This CR is introducing the extra empty lines in the generated test output and causing several test cases to fail on Windows.
> Attached the generated output for one of the unit test failures with extra space. (bucket1.q)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3320) Handle “CRLF” line endings to avoid the extra spacing in generated test outputs in Windows. (Utilities.Java :: readColumn)
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kanna Karanam updated HIVE-3320:
--------------------------------
Attachment: HIVE-3320.1.patch.txt
Attached the patch. CR is available at https://reviews.apache.org/r/6215/ . Thanks
> Handle “CRLF” line endings to avoid the extra spacing in generated test outputs in Windows. (Utilities.Java :: readColumn)
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3320
> URL: https://issues.apache.org/jira/browse/HIVE-3320
> Project: Hive
> Issue Type: Sub-task
> Components: CLI, Tests, Windows
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows
> Attachments: HIVE-3320.1.patch.txt, bucket1.q.out.patch.txt
>
>
> Existing functionality in Hive is looking for the “LF” character to extract the lines from generated output before writing to the streaming object. Whereas in Windows, the line endings are “CRLF” characters so it is leaving the “CR” character before writing each line to the streaming object. This CR is introducing the extra empty lines in the generated test output and causing several test cases to fail on Windows.
> Attached the generated output for one of the unit test failures with extra space. (bucket1.q)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira