You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/11/08 07:55:18 UTC
[GitHub] [shardingsphere] lanchengx opened a new pull request #13495: `set variable` statement test adjustment
lanchengx opened a new pull request #13495:
URL: https://github.com/apache/shardingsphere/pull/13495
Fixes https://github.com/apache/shardingsphere/issues/13460
Changes proposed in this pull request:
- Mock `ContextManager`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on a change in pull request #13495: `set variable` statement test adjustment
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on a change in pull request #13495:
URL: https://github.com/apache/shardingsphere/pull/13495#discussion_r745233339
##########
File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/test/java/org/apache/shardingsphere/proxy/backend/text/distsql/ral/common/set/executor/SetVariableExecutorTest.java
##########
@@ -40,7 +44,7 @@ public void assertExecuteWithTransactionType() {
BackendConnection connection = mock(BackendConnection.class);
when(connection.getTransactionStatus()).thenReturn(new TransactionStatus(TransactionType.XA));
new SetVariableExecutor(statement, connection).execute();
- Assert.assertThat(TransactionType.LOCAL.name(), is(connection.getTransactionStatus().getTransactionType().name()));
+ assertThat(TransactionType.LOCAL.name(), is(connection.getTransactionStatus().getTransactionType().name()));
Review comment:
Actual value is on the left.
##########
File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/test/java/org/apache/shardingsphere/proxy/backend/text/distsql/ral/common/set/executor/SetVariableExecutorTest.java
##########
@@ -49,15 +53,20 @@ public void assertExecuteWithAgent() {
BackendConnection connection = mock(BackendConnection.class);
new SetVariableExecutor(statement, connection).execute();
String expectedValue = SystemPropertyUtil.getSystemProperty(VariableEnum.AGENT_PLUGINS_ENABLED.name(), "default");
- Assert.assertThat(expectedValue, is("false"));
+ assertThat(expectedValue, is("false"));
Review comment:
Maybe the `expectedValue` here and below should be named `actualValue`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on pull request #13495: `set variable` statement test adjustment
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on pull request #13495:
URL: https://github.com/apache/shardingsphere/pull/13495#issuecomment-963750355
You may find the code of conduct in our documents
https://shardingsphere.apache.org/community/en/contribute/code-conduct/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #13495: `set variable` statement test adjustment
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #13495:
URL: https://github.com/apache/shardingsphere/pull/13495#issuecomment-963843898
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13495?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#13495](https://codecov.io/gh/apache/shardingsphere/pull/13495?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8ae5ab5) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a59d7cfaec64c5236d812ed4a34f5d7f55bf8d33?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a59d7cf) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/13495?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #13495 +/- ##
==========================================
Coverage 63.61% 63.61%
- Complexity 1628 1639 +11
==========================================
Files 2673 2693 +20
Lines 39985 40285 +300
Branches 6841 6893 +52
==========================================
+ Hits 25436 25628 +192
- Misses 12610 12709 +99
- Partials 1939 1948 +9
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/13495?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/text/distsql/ral/common/hint/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/13495/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L0hpbnRTb3VyY2VUeXBlLmphdmE=) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
| [...atabase/metadata/dialect/H2DataSourceMetaData.java](https://codecov.io/gh/apache/shardingsphere/pull/13495/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kYXRhYmFzZS9tZXRhZGF0YS9kaWFsZWN0L0gyRGF0YVNvdXJjZU1ldGFEYXRhLmphdmE=) | `82.35% <0.00%> (-17.65%)` | :arrow_down: |
| [...te/AlterDatabaseDiscoveryRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/13495/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1kaXN0c3FsL3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiZGlzY292ZXJ5L2Rpc3RzcWwvaGFuZGxlci91cGRhdGUvQWx0ZXJEYXRhYmFzZURpc2NvdmVyeVJ1bGVTdGF0ZW1lbnRVcGRhdGVyLmphdmE=) | `47.36% <0.00%> (-6.64%)` | :arrow_down: |
| [...re/job/check/source/AbstractDataSourceChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/13495/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvY2hlY2svc291cmNlL0Fic3RyYWN0RGF0YVNvdXJjZUNoZWNrZXIuamF2YQ==) | `32.00% <0.00%> (-2.79%)` | :arrow_down: |
| [.../loader/dialect/PostgreSQLTableMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/13495/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9zY2hlbWEvYnVpbGRlci9sb2FkZXIvZGlhbGVjdC9Qb3N0Z3JlU1FMVGFibGVNZXRhRGF0YUxvYWRlci5qYXZh) | `82.89% <0.00%> (-2.59%)` | :arrow_down: |
| [...enerator/impl/EncryptProjectionTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/13495/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9FbmNyeXB0UHJvamVjdGlvblRva2VuR2VuZXJhdG9yLmphdmE=) | `41.57% <0.00%> (-2.25%)` | :arrow_down: |
| [...ling/core/common/datasource/DataSourceWrapper.java](https://codecov.io/gh/apache/shardingsphere/pull/13495/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9jb21tb24vZGF0YXNvdXJjZS9EYXRhU291cmNlV3JhcHBlci5qYXZh) | `69.56% <0.00%> (-1.87%)` | :arrow_down: |
| [...here/dbdiscovery/mgr/MGRDatabaseDiscoveryType.java](https://codecov.io/gh/apache/shardingsphere/pull/13495/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1wcm92aWRlci9zaGFyZGluZ3NwaGVyZS1kYi1kaXNjb3ZlcnktbWdyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYmRpc2NvdmVyeS9tZ3IvTUdSRGF0YWJhc2VEaXNjb3ZlcnlUeXBlLmphdmE=) | `28.48% <0.00%> (-1.33%)` | :arrow_down: |
| [...scaling/core/job/task/inventory/InventoryTask.java](https://codecov.io/gh/apache/shardingsphere/pull/13495/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvdGFzay9pbnZlbnRvcnkvSW52ZW50b3J5VGFzay5qYXZh) | `75.55% <0.00%> (ø)` | |
| [...ling/core/config/InventoryDumperConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/13495/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9jb25maWcvSW52ZW50b3J5RHVtcGVyQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <0.00%> (ø)` | |
| ... and [70 more](https://codecov.io/gh/apache/shardingsphere/pull/13495/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13495?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13495?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a59d7cf...8ae5ab5](https://codecov.io/gh/apache/shardingsphere/pull/13495?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN merged pull request #13495: `set variable` statement test adjustment
Posted by GitBox <gi...@apache.org>.
TeslaCN merged pull request #13495:
URL: https://github.com/apache/shardingsphere/pull/13495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] lanchengx commented on pull request #13495: `set variable` statement test adjustment
Posted by GitBox <gi...@apache.org>.
lanchengx commented on pull request #13495:
URL: https://github.com/apache/shardingsphere/pull/13495#issuecomment-963762789
> You may find the code of conduct in our documents https://shardingsphere.apache.org/community/en/contribute/code-conduct/
Thanks a lot, I will pay more attention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] lanchengx commented on pull request #13495: `set variable` statement test adjustment
Posted by GitBox <gi...@apache.org>.
lanchengx commented on pull request #13495:
URL: https://github.com/apache/shardingsphere/pull/13495#issuecomment-962905863
@TeslaCN could you have a review ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org