You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by si...@apache.org on 2011/05/22 17:58:40 UTC

svn commit: r1126009 - /incubator/ognl/trunk/src/main/java/org/apache/commons/ognl/NumericExpression.java

Author: simonetripodi
Date: Sun May 22 15:58:40 2011
New Revision: 1126009

URL: http://svn.apache.org/viewvc?rev=1126009&view=rev
Log:
fix for unstable build #84

Modified:
    incubator/ognl/trunk/src/main/java/org/apache/commons/ognl/NumericExpression.java

Modified: incubator/ognl/trunk/src/main/java/org/apache/commons/ognl/NumericExpression.java
URL: http://svn.apache.org/viewvc/incubator/ognl/trunk/src/main/java/org/apache/commons/ognl/NumericExpression.java?rev=1126009&r1=1126008&r2=1126009&view=diff
==============================================================================
--- incubator/ognl/trunk/src/main/java/org/apache/commons/ognl/NumericExpression.java (original)
+++ incubator/ognl/trunk/src/main/java/org/apache/commons/ognl/NumericExpression.java Sun May 22 15:58:40 2011
@@ -111,7 +111,7 @@ public abstract class NumericExpression
         if ( context.getCurrentType() != null && !context.getCurrentType().isPrimitive()
             && context.getCurrentObject() != null && Number.class.isInstance( context.getCurrentObject() ) )
         {
-            ret.append( "((")
+            ret = new StringBuilder( "((")
                 .append( ExpressionCompiler.getCastString( context.getCurrentObject().getClass() ))
                 .append( ")")
                 .append( ret)
@@ -127,13 +127,15 @@ public abstract class NumericExpression
         }
         else if ( context.getCurrentType() != null && String.class.isAssignableFrom( context.getCurrentType() ) )
         {
-            ret.append( "Double.parseDouble(").append( ")" );
+            ret = new StringBuilder( "Double.parseDouble(")
+                .append( ret.toString() )
+                .append( ")" );
             context.setCurrentType( Double.TYPE );
         }
 
         if ( NumericExpression.class.isInstance( child ) )
         {
-            ret.append( "(" ).append( ret ).append( ")" );
+            ret = new StringBuilder( "(" ).append( ret ).append( ")" );
         }
 
         return ret.toString();