[GitHub] spark pull request: [SPARK-7140][MLLIB] only scan the first 16 ent...

[jkbradley <gi...@git.apache.org>]

Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5697#discussion_r29116184
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala ---
    @@ -556,6 +579,28 @@ class SparseVector(
           i += 1
         }
       }
    +
    +  override def hashCode(): Int = {
    --- End diff --
    
    OK, sounds fine.  Curious: Why do DenseVector and SparseVector need to implement the same hash code?  I was thinking DenseVectors could stay as they are (the first 16 elements), while SparseVectors could look at the first 16 non-zeros to reduce collisions.  But I'm not familiar with this code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org