You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:32:19 UTC

[GitHub] [arrow] BryanCutler commented on pull request #10513: ARROW-13044: [Java] Change UnionVector and DenseUnionVector to extend AbstractContainerVector

BryanCutler commented on pull request #10513:
URL: https://github.com/apache/arrow/pull/10513#issuecomment-859790741


   Ah you're right @liyafan82 , I must have mixed it up with `ValueVector`, so probably extension types won't work for struct and union types. I still think it's right for `UnionVector` to extend `AbstractContainerVector`, but probably not `BaseValueVector`. Maybe the constraint for `ExtensionTypeVector` should be relaxed to `ValueVector`? What do you and @lidavidm think? 
   cc @emkornfield 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org