You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/24 19:30:19 UTC

[GitHub] [airflow] derkuci commented on pull request #20473: SSHOperator.execute() returns str regardless of enable_xcom_pickling

derkuci commented on pull request #20473:
URL: https://github.com/apache/airflow/pull/20473#issuecomment-1000920704


   > If I understand this correctly, the change is backward incompatible, right? It does not preclude the possibility, but must be clarified so the next SSH provider version can be released correctly.
   
   You're correct.  The change makes `SSHOperator` more consistent with other operators and across configurations (i.e., with and without XCom pickling), but breaks the compatibility with its current behavior (hence the tests were also updated).
   
   I personally believe this is a good thing, but have no clue if it is aligned with the ideas of airflow developers.  Hence this PR for discussions.  If this is OK with you guys, I will try to fix the doc wherever applicable (best with some help as I am even less familiar with the doc).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org