[GitHub] Menardi commented on a change in pull request #848: Remove deprecated platforms from plugin page

[GitBox <gi...@apache.org>]

Menardi commented on a change in pull request #848: Remove deprecated platforms from plugin page
URL: https://github.com/apache/cordova-docs/pull/848#discussion_r209200422
 
 

 ##########
 File path: www/static/plugins/supportedplatforms.jsx
 ##########
 @@ -1,83 +1,32 @@
-var Preact = require('preact'),
-    h = require('preact').h,
-    createClass = require('preact-compat').createClass,
-    PlatformButton = require('./platformbutton.jsx');
+const Preact = require('preact');
+const h = require('preact').h;
+const createClass = require('preact-compat').createClass;
+const PlatformButton = require('./platformbutton.jsx');
 
-var SupportedPlatforms = createClass({
-    render: function() {
-        var keywords = this.props.keywords;
-        var sortedPlatforms = [
-            {present:false, icon: "android", alt:"Android"},
-            {present:false, icon: "ios", alt:"iOS"},
-            {present:false, icon: "windows", alt:"Windows"},
-            {present:false, icon: "blackberry", alt:"Blackberry"},
-            {present:false, icon: "ubuntu", alt:"Ubuntu"},
-            {present:false, icon: "firefox", alt:"FirefoxOS"},
-            {present:false, icon: "webos", alt:"webOS"},
-            {present:false, icon: "fireos", alt:"FireOS"},
-            {present:false, icon: "osx", alt:"OS X"},
-            {present:false, icon: "browser", alt:"Browser"}
+const SupportedPlatforms = createClass({
+    render: function () {
+        // Collection of the npm package keywords.
+        const keywords = new Set(this.props.keywords);
 
 Review comment:
   @erisu Looks good to me, feel free to merge it (I'm still sorting out my Apache / Github permissions)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org