[jira] [Work logged] (TS-5103) Always tunnel non-keepalive HTTP request if tr-pass enabled

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TS-5103?focusedWorklogId=34653&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34653 ]

ASF GitHub Bot logged work on TS-5103:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Jan/17 14:17
            Start Date: 04/Jan/17 14:17
    Worklog Time Spent: 10m 
      Work Description: Github user shinrich commented on the issue:

    https://github.com/apache/trafficserver/pull/1271
  
    Yes, this looks like the correct change to me.  We should be checking that there is more data on the ua_buffer_reader.  In this case, there should always be data on the ua_raw_buffer_reader, so we will be incorrectly blind tunneling GET requests without keep alive enabled. (I think).
    
    We only want to flip to tunnel mode if there is data after the already parsed header which would be reflected by the  ua_buffer_reader.


Issue Time Tracking
-------------------

    Worklog Id:     (was: 34653)
    Time Spent: 40m  (was: 0.5h)

> Always tunnel non-keepalive HTTP request if tr-pass enabled
> -----------------------------------------------------------
>
>                 Key: TS-5103
>                 URL: https://issues.apache.org/jira/browse/TS-5103
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP
>            Reporter: Oknet Xu
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Should use ua_buffer_reader instead of ua_raw_buffer_reader.
> {code}
>       // If we had a GET request that has data after the
>       // get request, do blind tunnel
>     } else if (state == PARSE_DONE && t_state.hdr_info.client_request.method_get_wksidx() == HTTP_WKSIDX_GET &&
>                ua_raw_buffer_reader->read_avail() > 0 && !t_state.hdr_info.client_request.is_keep_alive_set()) {
>       do_blind_tunnel = true;
>     }    
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)