[GitHub] [hadoop] goiri commented on a change in pull request #3303: HDFS-16174. Implement temp file and dir in cc files

[GitBox <gi...@apache.org>]

goiri commented on a change in pull request #3303:
URL: https://github.com/apache/hadoop/pull/3303#discussion_r689684805



##########
File path: hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tests/configuration_test.h
##########
@@ -114,105 +111,6 @@ void writeDamagedConfig(const std::string& filename, Args... args) {
   out.open(filename);
   out << stream.rdbuf();
 }
-
-// TempDir: is deleted on destruction
-class TempFile {

Review comment:
       Other than reducing the size of this file, is there any benefit of having this? Or this is just a refactor at this point?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org