You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2017/07/06 04:11:52 UTC
Review Request 60675: Fixed compilation failure in port-mapping
network isolator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60675/
-----------------------------------------------------------
Review request for mesos and Joseph Wu.
Bugs: MESOS-7762
https://issues.apache.org/jira/browse/MESOS-7762
Repository: mesos
Description
-------
Fixed compilation failure in port-mapping network isolator.
Diffs
-----
src/linux/routing/filter/icmp.hpp bc0aed0f4fc7c48f06cece14aa9ec43d7fa36bc4
src/linux/routing/route.hpp 01d4e7582b19a38bc39f8c394121fe0bed2c0d87
src/linux/routing/route.cpp ceeaf8e557a88569e1f15b3ffc5f0746b66ea638
src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 9d38289c7161d5e931053b587d115684ccc44c94
src/slave/containerizer/mesos/isolators/network/port_mapping.cpp cd008aaebcd42554a9a81d2b059269546f59c966
src/tests/containerizer/port_mapping_tests.cpp 16e015a8ac53a4aa5336b60c40228720b5f6910a
Diff: https://reviews.apache.org/r/60675/diff/1/
Testing
-------
make check
Thanks,
Avinash sridharan
Re: Review Request 60675: Fixed compilation failure in port-mapping
network isolator.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60675/#review179753
-----------------------------------------------------------
Patch looks great!
Reviews applied: [60674, 60675]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On July 6, 2017, 4:11 a.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60675/
> -----------------------------------------------------------
>
> (Updated July 6, 2017, 4:11 a.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-7762
> https://issues.apache.org/jira/browse/MESOS-7762
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed compilation failure in port-mapping network isolator.
>
>
> Diffs
> -----
>
> src/linux/routing/filter/icmp.hpp bc0aed0f4fc7c48f06cece14aa9ec43d7fa36bc4
> src/linux/routing/route.hpp 01d4e7582b19a38bc39f8c394121fe0bed2c0d87
> src/linux/routing/route.cpp ceeaf8e557a88569e1f15b3ffc5f0746b66ea638
> src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 9d38289c7161d5e931053b587d115684ccc44c94
> src/slave/containerizer/mesos/isolators/network/port_mapping.cpp cd008aaebcd42554a9a81d2b059269546f59c966
> src/tests/containerizer/port_mapping_tests.cpp 16e015a8ac53a4aa5336b60c40228720b5f6910a
>
>
> Diff: https://reviews.apache.org/r/60675/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 60675: Fixed compilation failure in port-mapping
network isolator.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60675/#review179755
-----------------------------------------------------------
Patch looks great!
Reviews applied: [60674, 60675]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On July 6, 2017, 5:03 a.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60675/
> -----------------------------------------------------------
>
> (Updated July 6, 2017, 5:03 a.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-7762
> https://issues.apache.org/jira/browse/MESOS-7762
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed compilation failure in port-mapping network isolator.
>
>
> Diffs
> -----
>
> src/linux/routing/filter/icmp.hpp bc0aed0f4fc7c48f06cece14aa9ec43d7fa36bc4
> src/linux/routing/route.hpp 01d4e7582b19a38bc39f8c394121fe0bed2c0d87
> src/linux/routing/route.cpp ceeaf8e557a88569e1f15b3ffc5f0746b66ea638
> src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 9d38289c7161d5e931053b587d115684ccc44c94
> src/slave/containerizer/mesos/isolators/network/port_mapping.cpp cd008aaebcd42554a9a81d2b059269546f59c966
> src/tests/containerizer/port_mapping_tests.cpp 16e015a8ac53a4aa5336b60c40228720b5f6910a
>
>
> Diff: https://reviews.apache.org/r/60675/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 60675: Fixed compilation failure in port-mapping
network isolator.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60675/#review179768
-----------------------------------------------------------
Fix it, then Ship it!
src/linux/routing/filter/icmp.hpp
Line 48 (original), 48 (patched)
<https://reviews.apache.org/r/60675/#comment254604>
Update the same comment in `src/linux/routing/filter/ip.hpp`?
- James Peach
On July 6, 2017, 5:03 a.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60675/
> -----------------------------------------------------------
>
> (Updated July 6, 2017, 5:03 a.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-7762
> https://issues.apache.org/jira/browse/MESOS-7762
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed compilation failure in port-mapping network isolator.
>
>
> Diffs
> -----
>
> src/linux/routing/filter/icmp.hpp bc0aed0f4fc7c48f06cece14aa9ec43d7fa36bc4
> src/linux/routing/route.hpp 01d4e7582b19a38bc39f8c394121fe0bed2c0d87
> src/linux/routing/route.cpp ceeaf8e557a88569e1f15b3ffc5f0746b66ea638
> src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 9d38289c7161d5e931053b587d115684ccc44c94
> src/slave/containerizer/mesos/isolators/network/port_mapping.cpp cd008aaebcd42554a9a81d2b059269546f59c966
> src/tests/containerizer/port_mapping_tests.cpp 16e015a8ac53a4aa5336b60c40228720b5f6910a
>
>
> Diff: https://reviews.apache.org/r/60675/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 60675: Fixed compilation failure in port-mapping
network isolator.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60675/#review179781
-----------------------------------------------------------
Patch looks great!
Reviews applied: [60674, 60675]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On July 6, 2017, 1:54 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60675/
> -----------------------------------------------------------
>
> (Updated July 6, 2017, 1:54 p.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-7762
> https://issues.apache.org/jira/browse/MESOS-7762
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed compilation failure in port-mapping network isolator.
>
>
> Diffs
> -----
>
> src/linux/routing/filter/icmp.hpp bc0aed0f4fc7c48f06cece14aa9ec43d7fa36bc4
> src/linux/routing/filter/ip.hpp ee416bc0c30dfd2b737d0dc32430d30a6dfdff46
> src/linux/routing/route.hpp 01d4e7582b19a38bc39f8c394121fe0bed2c0d87
> src/linux/routing/route.cpp ceeaf8e557a88569e1f15b3ffc5f0746b66ea638
> src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 9d38289c7161d5e931053b587d115684ccc44c94
> src/slave/containerizer/mesos/isolators/network/port_mapping.cpp cd008aaebcd42554a9a81d2b059269546f59c966
> src/tests/containerizer/port_mapping_tests.cpp 16e015a8ac53a4aa5336b60c40228720b5f6910a
>
>
> Diff: https://reviews.apache.org/r/60675/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 60675: Fixed compilation failure in port-mapping
network isolator.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60675/
-----------------------------------------------------------
(Updated July 6, 2017, 1:54 p.m.)
Review request for mesos and Joseph Wu.
Changes
-------
Addressed Jame's comments.
Bugs: MESOS-7762
https://issues.apache.org/jira/browse/MESOS-7762
Repository: mesos
Description
-------
Fixed compilation failure in port-mapping network isolator.
Diffs (updated)
-----
src/linux/routing/filter/icmp.hpp bc0aed0f4fc7c48f06cece14aa9ec43d7fa36bc4
src/linux/routing/filter/ip.hpp ee416bc0c30dfd2b737d0dc32430d30a6dfdff46
src/linux/routing/route.hpp 01d4e7582b19a38bc39f8c394121fe0bed2c0d87
src/linux/routing/route.cpp ceeaf8e557a88569e1f15b3ffc5f0746b66ea638
src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 9d38289c7161d5e931053b587d115684ccc44c94
src/slave/containerizer/mesos/isolators/network/port_mapping.cpp cd008aaebcd42554a9a81d2b059269546f59c966
src/tests/containerizer/port_mapping_tests.cpp 16e015a8ac53a4aa5336b60c40228720b5f6910a
Diff: https://reviews.apache.org/r/60675/diff/3/
Changes: https://reviews.apache.org/r/60675/diff/2-3/
Testing
-------
make check
Thanks,
Avinash sridharan
Re: Review Request 60675: Fixed compilation failure in port-mapping
network isolator.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60675/
-----------------------------------------------------------
(Updated July 6, 2017, 5:03 a.m.)
Review request for mesos and Joseph Wu.
Changes
-------
Fixed another missing `IPNetwork` instance.
Bugs: MESOS-7762
https://issues.apache.org/jira/browse/MESOS-7762
Repository: mesos
Description
-------
Fixed compilation failure in port-mapping network isolator.
Diffs (updated)
-----
src/linux/routing/filter/icmp.hpp bc0aed0f4fc7c48f06cece14aa9ec43d7fa36bc4
src/linux/routing/route.hpp 01d4e7582b19a38bc39f8c394121fe0bed2c0d87
src/linux/routing/route.cpp ceeaf8e557a88569e1f15b3ffc5f0746b66ea638
src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 9d38289c7161d5e931053b587d115684ccc44c94
src/slave/containerizer/mesos/isolators/network/port_mapping.cpp cd008aaebcd42554a9a81d2b059269546f59c966
src/tests/containerizer/port_mapping_tests.cpp 16e015a8ac53a4aa5336b60c40228720b5f6910a
Diff: https://reviews.apache.org/r/60675/diff/2/
Changes: https://reviews.apache.org/r/60675/diff/1-2/
Testing
-------
make check
Thanks,
Avinash sridharan