[GitHub] [helix] lei-xia commented on a change in pull request #359: Dynamically change the processor thread name when consuming event

[GitBox <gi...@apache.org>]

lei-xia commented on a change in pull request #359: Dynamically change the processor thread name when consuming event
URL: https://github.com/apache/helix/pull/359#discussion_r309026379
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
 ##########
 @@ -1165,7 +1163,11 @@ public void run() {
               + _processorName);
       while (!isInterrupted()) {
         try {
-          handleEvent(_eventBlockingQueue.take(), _cache);
+          ClusterEvent newClusterEvent = _eventBlockingQueue.take();
+          String threadName = String.format(
+              "HelixController-pipeline-%s-(%s)", _processorName, newClusterEvent.getEventId());
 
 Review comment:
   can we include clusterName here in the thread name? What is the processor name here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services