You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Colin Ma <ju...@intel.com> on 2015/08/19 08:14:37 UTC

Review Request 37600: SQOOP-2508: Sqoop2: Findbugs: Fix warnings in connector-sdk module

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37600/
-----------------------------------------------------------

Review request for Sqoop.


Repository: sqoop-sqoop2


Description
-------

Fix warnings in connector-sdk module


Diffs
-----

  connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopAvroUtils.java 857271a 
  connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java 2a7aa1b 
  connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java fef8202 
  connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormat.java 0fac41a 

Diff: https://reviews.apache.org/r/37600/diff/


Testing
-------


Thanks,

Colin Ma


Re: Review Request 37600: SQOOP-2508: Sqoop2: Findbugs: Fix warnings in connector-sdk module

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37600/#review95966
-----------------------------------------------------------

Ship it!


Ship It!

- Jarek Cecho


On Aug. 20, 2015, 5:47 a.m., Colin Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37600/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2015, 5:47 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Fix warnings in connector-sdk module
> 
> 
> Diffs
> -----
> 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopAvroUtils.java 857271a 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java 2a7aa1b 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java fef8202 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormat.java 0fac41a 
>   connector/connector-sdk/src/test/java/org/apache/sqoop/connector/common/TestSqoopIDFUtils.java f9b676b 
> 
> Diff: https://reviews.apache.org/r/37600/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colin Ma
> 
>


Re: Review Request 37600: SQOOP-2508: Sqoop2: Findbugs: Fix warnings in connector-sdk module

Posted by Colin Ma <ju...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37600/
-----------------------------------------------------------

(Updated Aug. 20, 2015, 5:47 a.m.)


Review request for Sqoop.


Repository: sqoop-sqoop2


Description
-------

Fix warnings in connector-sdk module


Diffs (updated)
-----

  connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopAvroUtils.java 857271a 
  connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java 2a7aa1b 
  connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java fef8202 
  connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormat.java 0fac41a 
  connector/connector-sdk/src/test/java/org/apache/sqoop/connector/common/TestSqoopIDFUtils.java f9b676b 

Diff: https://reviews.apache.org/r/37600/diff/


Testing
-------


Thanks,

Colin Ma