[GitHub] [guacamole-server] jmuehlner commented on a change in pull request #251: GUACAMOLE-935: Free internals of rdpBitmap only when required (FreeRDP 2.0.0-rc0 and earlier).

[GitBox <gi...@apache.org>]

jmuehlner commented on a change in pull request #251: GUACAMOLE-935: Free internals of rdpBitmap only when required (FreeRDP 2.0.0-rc0 and earlier).
URL: https://github.com/apache/guacamole-server/pull/251#discussion_r369376969
 
 

 ##########
 File path: configure.ac
 ##########
 @@ -578,6 +578,30 @@ then
 
 fi
 
+# Variation in memory internal allocation/free behavior
+if test "x${have_freerdp2}" = "xyes"
+then
+
+    # FreeRDP 2.0.0-rc0 and older automatically free rdpBitmap and its
+    # associated data member within Bitmap_Free(), relying on the
+    # implementation-specific free handler to free only implementation-specific
+    # data. This changed in commit 2cf10cc, and implementations must now
+    # manually free all data associated with the rdpBitmap, even data which
+    # was not allocated by the implementation.
+    AC_MSG_CHECKING([whether Bitmap_Free() frees the rdpBitmap and its image data])
+    AC_EGREP_CPP([\"2.0.0-dev\"], [
+
+        #include <freerdp/version.h>
+        FREERDP_VERSION_FULL
 
 Review comment:
   What specifically are you looking for in the header file to indicate that we're on rc1+?
   
   Is it this `FREERDP_VERSION_FULL` string?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services