You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/12/15 11:50:05 UTC
[GitHub] [incubator-doris] Henry2SS opened a new pull request #7407: [fix] fix sql block,move it from ConnectProcess to StmtExecutor
Henry2SS opened a new pull request #7407:
URL: https://github.com/apache/incubator-doris/pull/7407
## Proposed changes
Close related #7405 (replace it with issue number if it exists).
Describe the overview of changes, and introduce why we need it.
As issue described.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [ ] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #7407: [fix] fix sql block,move it from ConnectProcessor to StmtExecutor
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #7407:
URL: https://github.com/apache/incubator-doris/pull/7407#issuecomment-995396089
Hi @Henry2SS , could you please update the `sql-block.md` document to explain this. Maybe:
```
支持按用户配置SQL黑名单，通过正则匹配的方式拒绝指定SQL。
该功能仅用于限制查询语句，并且不会限制 explain 语句的执行。
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Henry2SS commented on pull request #7407: [fix] fix sql block,move it from ConnectProcessor to StmtExecutor
Posted by GitBox <gi...@apache.org>.
Henry2SS commented on pull request #7407:
URL: https://github.com/apache/incubator-doris/pull/7407#issuecomment-995399203
> Hi @Henry2SS , could you please update the `sql-block.md` document to explain this. Maybe:
>
> ```
> 支持按用户配置SQL黑名单，通过正则匹配的方式拒绝指定SQL。
> 该功能仅用于限制查询语句，并且不会限制 explain 语句的执行。
> ```
>
> both Chinese and English
Hi,
It is explained in another PR #7403. And I would like to add some unit-tests to avoid sql block's blocking ALTER/DROP operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Henry2SS edited a comment on pull request #7407: [fix] fix sql block,move it from ConnectProcessor to StmtExecutor
Posted by GitBox <gi...@apache.org>.
Henry2SS edited a comment on pull request #7407:
URL: https://github.com/apache/incubator-doris/pull/7407#issuecomment-995399203
> Hi @Henry2SS , could you please update the `sql-block.md` document to explain this. Maybe:
>
> ```
> 支持按用户配置SQL黑名单，通过正则匹配的方式拒绝指定SQL。
> 该功能仅用于限制查询语句，并且不会限制 explain 语句的执行。
> ```
>
> both Chinese and English
Hi,
It is explained in another PR #7403. And I would like to add some unit-tests to test that sql block doesn't block ALTER/DROP operations.
Anyway, I will update docs in this PR first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman edited a comment on pull request #7407: [fix] fix sql block,move it from ConnectProcessor to StmtExecutor
Posted by GitBox <gi...@apache.org>.
morningman edited a comment on pull request #7407:
URL: https://github.com/apache/incubator-doris/pull/7407#issuecomment-995396089
Hi @Henry2SS , could you please update the `sql-block.md` document to explain this. Maybe:
```
支持按用户配置SQL黑名单，通过正则匹配的方式拒绝指定SQL。
该功能仅用于限制查询语句，并且不会限制 explain 语句的执行。
```
both Chinese and English
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7407: [fix] fix sql block,move it from ConnectProcessor to StmtExecutor
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7407:
URL: https://github.com/apache/incubator-doris/pull/7407#issuecomment-998416592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Henry2SS edited a comment on pull request #7407: [fix] fix sql block,move it from ConnectProcessor to StmtExecutor
Posted by GitBox <gi...@apache.org>.
Henry2SS edited a comment on pull request #7407:
URL: https://github.com/apache/incubator-doris/pull/7407#issuecomment-995399203
> Hi @Henry2SS , could you please update the `sql-block.md` document to explain this. Maybe:
>
> ```
> 支持按用户配置SQL黑名单，通过正则匹配的方式拒绝指定SQL。
> 该功能仅用于限制查询语句，并且不会限制 explain 语句的执行。
> ```
>
> both Chinese and English
Hi,
It is explained in another PR #7403. And I would like to add some unit-tests to avoid sql block's blocking ALTER/DROP operations.
Anyway, I will update docs in this PR first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #7407: [fix] fix sql block,move it from ConnectProcessor to StmtExecutor
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #7407:
URL: https://github.com/apache/incubator-doris/pull/7407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org