You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2016/01/07 15:55:52 UTC
[GitHub] couchdb-fauxton pull request: remove useless grunt defaults
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/598
remove useless grunt defaults
the defaults are not used at all as all setting.json files
implement them, but make it harder for everyone to understand what
is happening.
additionally configuration should not be mixed into the
code as it turned out worthwile to don't mix config and code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton cleanup-gruntfile
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/598.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #598
----
commit ec3ef2045831ddde87153b06a1cee9228a894ad3
Author: Robert Kowalski <ro...@apache.org>
Date: 2016-01-07T14:54:37Z
remove useless grunt defaults
the defaults are not used at all as all setting.json files
implement them, but make it harder for everyone to understand what
is happening.
additionally configuration should not be mixed into the
code as it turned out worthwile to don't mix config and code.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: remove useless grunt defaults
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/598#issuecomment-169977942
> We always override it, true, but it looks like we don't need to for Fauxton, no?
we have to override them for fauxton:
```
"requirejs": "./js/{REQUIREJS_FILE}",
"css": "./css/{CSS_FILE}",
```
is wrong, it will never work (the curly braces are not replaced)
> Instead, in addition to dropping the code like you've done, could we add a validation check to ensure the required params are there: src, dest, and the required vars?
the feature for checking the settings.json for required fields is a nice idea. i would like to keep that feature separated from the cleanup.
the idea is nice, but so far i am not aware that people had issues when creating those files. i personally would like to wait until it gets an issue for us. i am also sure it will get outdated very soon, as people add more things to the settings.json, but forget to update the check.
but i also don't want to block you, if you think it is something you should add right now, feel free to add it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: remove useless grunt defaults
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/598
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: remove useless grunt defaults
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/598#issuecomment-170061847
Cool, thanks Robert! It’s fine - it was just a niggle I had with the ticket. It's fine as it is, thanks for the explanation. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: remove useless grunt defaults
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/598#issuecomment-170527613
merged as 57883a2b4f97c82288e4c589857879eede4861ff
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: remove useless grunt defaults
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/598#issuecomment-169751605
True, this chunk of code isn't being used, but I disagree it's useless. We always override it, true, but it looks like we don't need to for Fauxton, no? (i.e. we could rely on the development or production defaults to take care of providing those default values). But besides that, I kind of like being able to see at a glance exactly what info grunt it looking for to create the build.
Instead, in addition to dropping the code like you've done, could we add a validation check to ensure the required params are there: src, dest, and the required vars? That could output a nice juicy "such and such is missing" error to ensure grunt gets what it wants. I realize this isn't strictly needed now, but for people editing / creating new settings files it may be helpful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---