You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by tpetazzoni <gi...@git.apache.org> on 2017/08/26 14:25:19 UTC
[GitHub] thrift pull request #1336: configure.ac, Makefile.am: introduce THRIFT varia...
GitHub user tpetazzoni opened a pull request:
https://github.com/apache/thrift/pull/1336
configure.ac, Makefile.am: introduce THRIFT variable to support cross…
…-compilation
The thrift build system currently assumes that the thrift compiler is
always available in $(top_builddir)/compiler/cpp/thrift. However, in a
cross-compilation context, this location contains the thrift compiler
built for the target... which obviously will not run on the build
machine.
In order to support such cross-compilation situation, we introduce the
THRIFT variable as a an argument for the configure script (using
AC_ARG_VAR). If not specified, it defaults to the existing value of
using compiler/cpp/thrift from the build directory, but it can be
overridden when calling ./configure.
Note that $(top_builddir) cannot be used within the configure script,
so we simply use `pwd`, which is the same as the top_builddir.
Signed-off-by: Thomas Petazzoni <th...@free-electrons.com>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tpetazzoni/thrift cross-compilation-support
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1336.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1336
----
commit e87142cc64e5a3f2c827300e1ea45c9ae3997aa4
Author: Thomas Petazzoni <th...@free-electrons.com>
Date: 2017-08-25T22:10:40Z
configure.ac, Makefile.am: introduce THRIFT variable to support cross-compilation
The thrift build system currently assumes that the thrift compiler is
always available in $(top_builddir)/compiler/cpp/thrift. However, in a
cross-compilation context, this location contains the thrift compiler
built for the target... which obviously will not run on the build
machine.
In order to support such cross-compilation situation, we introduce the
THRIFT variable as a an argument for the configure script (using
AC_ARG_VAR). If not specified, it defaults to the existing value of
using compiler/cpp/thrift from the build directory, but it can be
overridden when calling ./configure.
Note that $(top_builddir) cannot be used within the configure script,
so we simply use `pwd`, which is the same as the top_builddir.
Signed-off-by: Thomas Petazzoni <th...@free-electrons.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1336: configure.ac, Makefile.am: introduce THRIFT variable to ...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1336
Wouldn't we want the value in configure.ac to percolate through? Why override it in every Makefile.am?
---
[GitHub] thrift pull request #1336: configure.ac, Makefile.am: introduce THRIFT varia...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1336
---
[GitHub] thrift issue #1336: configure.ac, Makefile.am: introduce THRIFT variable to ...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1336
I opened THRIFT-4325 for this.
---
[GitHub] thrift issue #1336: configure.ac, Makefile.am: introduce THRIFT variable to ...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1336
I like the changes as proposed; this needs an Apache Jira ticket stating the problem and resolution in order to get merged.
https://thrift.apache.org/docs/HowToContribute
Thanks!
---
[GitHub] thrift issue #1336: configure.ac, Makefile.am: introduce THRIFT variable to ...
Posted by tpetazzoni <gi...@git.apache.org>.
Github user tpetazzoni commented on the issue:
https://github.com/apache/thrift/pull/1336
Well, my patch precisely removes the override in every Makefile.am, so I'm not sure to understand your question.
---
[GitHub] thrift issue #1336: configure.ac, Makefile.am: introduce THRIFT variable to ...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1336
Thanks, it was late when I posted the comment and I misread the change! If there's any way you could rebase on master, squash, and force push that will kick off another CI build to validate the fix.
---