You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/02/12 02:59:06 UTC
[GitHub] [kafka] ableegoldman opened a new pull request #11750: KAFKA-12648: avoid modifying state until NamedTopology has passed validation
ableegoldman opened a new pull request #11750:
URL: https://github.com/apache/kafka/pull/11750
Previously we were only verifying the new query could be added after we had already inserted it into the TopologyMetadata, so we need to move the validation upfront.
Also adds a test case for this and improves handling of NPE in case of future or undiscovered bugs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang merged pull request #11750: KAFKA-12648: avoid modifying state until NamedTopology has passed validation
Posted by GitBox <gi...@apache.org>.
guozhangwang merged pull request #11750:
URL: https://github.com/apache/kafka/pull/11750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #11750: KAFKA-12648: avoid modifying state until NamedTopology has passed validation
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #11750:
URL: https://github.com/apache/kafka/pull/11750#issuecomment-1040793346
Merged to trunk, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #11750: KAFKA-12648: avoid modifying state until NamedTopology has passed validation
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #11750:
URL: https://github.com/apache/kafka/pull/11750#issuecomment-1036983791
@ableegoldman the change LGTM, but streams:checkstyleMain failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org