You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/11/10 11:32:41 UTC

[GitHub] [incubator-echarts] susiwen8 opened a new pull request #13593: Fix(slider): custom dataset's dimension might not have `open` dim

susiwen8 opened a new pull request #13593:
URL: https://github.com/apache/incubator-echarts/pull/13593


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   Validate `dim` whether it's existed in  `_dimensionInfos `
   
   ### Fixed issues
   Close #13571 
   
   ## Details
   
   ### Before: What was the problem?
   
   ![Screen Shot 2020-11-10 at 19 30 17](https://user-images.githubusercontent.com/20318608/98668680-31ed6580-238b-11eb-9fe4-7e5f929347c8.png)
   
   
   
   ### After: How is it fixed in this PR?
   
   ![Screen Shot 2020-11-10 at 19 31 06](https://user-images.githubusercontent.com/20318608/98668765-4df10700-238b-11eb-9184-6c341329c0dc.png)
   
   
   
   
   ## Usage
   
   ### Are there any API changes?
   
   - [ ] The API has been changed.
   
   <!-- LIST THE API CHANGES HERE -->
   
   
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13593: Fix(slider): custom dataset's dimension might not have `open` dim

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13593:
URL: https://github.com/apache/incubator-echarts/pull/13593#issuecomment-724644983


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org