[jira] [Commented] (KAFKA-9342) Consider making all Kafka Streams DSL configuration classes immutable

["John Roesler (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006488#comment-17006488 ] 

John Roesler commented on KAFKA-9342:
-------------------------------------

Thanks for this. I also find it pretty annoying. I have suggestions that we could supply to the whole dsl to take care of this among other problems. 

I’ll write it up some time next week and link it here to see what you think. 

> Consider making all Kafka Streams DSL configuration classes immutable
> ---------------------------------------------------------------------
>
>                 Key: KAFKA-9342
>                 URL: https://issues.apache.org/jira/browse/KAFKA-9342
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Levani Kokhreidze
>            Priority: Major
>
> Currently, Kafka Streams DSL config classes are mix of *mutable* _org.apache.kafka.streams.kstream.Consumed, org.apache.kafka.streams.kstream.Materialized_ and *immutable* _org.apache.kafka.streams.kstream.Joined, org.apache.kafka.streams.kstream.Grouped_ classes.
> Consider unifying all config classes of the DSL operations and make them immutable. Backward compatibility should be taken into account when making config classes immutable. For example, things may break if user has code similar to this:
>  
> {code:java}
> final Materialized<K, V, S> materialized = Materialized.as("my-store");
> if (someCondition()) {
>   materialized.withCachingDisabled();
> }{code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)