You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@texera.apache.org by gi...@apache.org on 2026/10/06 23:35:39 UTC
(texera) 01/02: refactor(frontend): remove the dead console-frame error style (#8881)
This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/texera.git
commit 007bf4328a2d0fdc9b0930eb6478e800db28e90c
Author: Xinyuan Lin <xi...@uci.edu>
AuthorDate: Tue Oct 6 23:16:23 2026 +0000
refactor(frontend): remove the dead console-frame error style (#8881)
### What changes were proposed in this PR?
Removes the `.error-message` rule from the console panel's stylesheet
(`console-frame.component.scss`), which styles nothing. **−10 lines.**
There is no behaviour change. The component uses emulated encapsulation,
its template has no `error-message` class (static or dynamic), its TS
adds no classes at runtime, and its ng-zorro children never render one.
### History
| | |
| --- | --- |
| **Introduced by** | #1304 (2021-08-20), "Properly update ConsoleFrame
when state changes", with a `<div class="error-message">` listing
operator errors |
| **Usage removed by** | #2195 (2023-11-09), "Enhance frontend error
reporting". It moved error display out of the console frame and deleted
that element |
It has been dead for nearly three years.
### Any related issues, documentation, discussions?
Closes #8880
### How was this PR tested?
No new tests; no spec referenced the class.
From `frontend/`:
- `npx ng test --watch=false
--include='**/console-frame.component.spec.ts'
--include='**/result-panel.component.spec.ts'`: 2 files, 105 tests, all
pass. The result-panel spec renders the console frame.
- `yarn format:ci`: clean.
- `npx ng build`: success.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---
.../result-panel/console-frame/console-frame.component.scss | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/frontend/src/app/workspace/component/result-panel/console-frame/console-frame.component.scss b/frontend/src/app/workspace/component/result-panel/console-frame/console-frame.component.scss
index 358c7bf8ed..6bd09740b8 100644
--- a/frontend/src/app/workspace/component/result-panel/console-frame/console-frame.component.scss
+++ b/frontend/src/app/workspace/component/result-panel/console-frame/console-frame.component.scss
@@ -27,16 +27,6 @@
user-select: text;
}
-.error-message {
- font-family: monaco, serif;
- font-size: 11px;
- font-style: normal;
- font-variant: normal;
- font-weight: 200;
- line-height: 14px;
- color: red;
-}
-
.console-toolbar {
flex: 0 0 auto;
display: flex;