Re: [PR] Pipe: Support mod transfer in pipe tsFiles & schema region snapshot transferring logic [iotdb]

["SteveYurongSu (via GitHub)" <gi...@apache.org>]

SteveYurongSu commented on code in PR #11998:
URL: https://github.com/apache/iotdb/pull/11998#discussion_r1540549708


##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/consensus/statemachine/ConfigRegionStateMachine.java:
##########
@@ -197,12 +198,33 @@ protected DataSet read(ConfigPhysicalPlan plan) {
 
   @Override
   public boolean takeSnapshot(File snapshotDir) {
-    return executor.takeSnapshot(snapshotDir);
+    if (executor.takeSnapshot(snapshotDir)) {
+      try {
+        PipeConfigNodeAgent.runtime()
+            .listener()
+            .tryListenToSnapshots(ConfignodeSnapshotParser.getSnapshots());
+        return true;
+      } catch (IOException e) {
+        LOGGER.error(
+            "Config Region Listening Queue Listen to snapshot failed, the historical data may not be transferred.");

Review Comment:
   ```suggestion
           LOGGER.error(
               "Config Region Listening Queue Listen to snapshot failed, the historical data may not be transferred.", e);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org