[GitHub] sv2000 commented on a change in pull request #2548: [GOBBLIN-677] - Allow early termination of Gobblin jobs based on a predicate on the job progress

[GitBox <gi...@apache.org>]

sv2000 commented on a change in pull request #2548: [GOBBLIN-677] - Allow early termination of Gobblin jobs based on a predicate on the job progress
URL: https://github.com/apache/incubator-gobblin/pull/2548#discussion_r256496993
 
 

 ##########
 File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/mapreduce/MRJobLauncher.java
 ##########
 @@ -170,6 +181,12 @@ public MRJobLauncher(Properties jobProps, Configuration conf, SharedResourcesBro
       throws Exception {
     super(jobProps, metadataTags);
 
+    this.fsm = new FiniteStateMachine.Builder<MRJobLauncherState>()
 
 Review comment:
   This FSM instance (and the associated states) looks generic enough that it can be moved out of this class. Can we have a FSM factory class that builds out specific FSM types and hands it back to the caller?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services