You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by vladimirtkach <gi...@git.apache.org> on 2018/03/17 15:29:54 UTC

[GitHub] drill pull request #1174: DRILL-6250: Sqlline start command with password ap...

GitHub user vladimirtkach opened a pull request:

    https://github.com/apache/drill/pull/1174

    DRILL-6250: Sqlline start command with password appears in the sqllin…

    …e.log

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vladimirtkach/drill DRILL-6250

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/1174.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1174
    
----
commit 36df1c291bc457b11dd0f7efaafa0065d9497d66
Author: Vladimir Tkach <vo...@...>
Date:   2018-03-17T15:27:10Z

    DRILL-6250: Sqlline start command with password appears in the sqlline.log

----


---

[GitHub] drill issue #1174: DRILL-6250: Sqlline start command with password appears i...

Posted by vladimirtkach <gi...@git.apache.org>.

Github user vladimirtkach commented on the issue:

    https://github.com/apache/drill/pull/1174
  
    @arina-ielchiieva addressed code review  comments


---

[GitHub] drill pull request #1174: DRILL-6250: Sqlline start command with password ap...

Posted by arina-ielchiieva <gi...@git.apache.org>.

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1174#discussion_r175368114
  
    --- Diff: common/src/main/java/org/apache/drill/common/config/DrillConfig.java ---
    @@ -52,8 +52,8 @@
       public DrillConfig(Config config) {
         super(config);
         logger.debug("Setting up DrillConfig object.");
    -    logger.trace("Given Config object is:\n{}",
    -                 config.root().render(ConfigRenderOptions.defaults()));
    +    logger.trace("Given Config object is:\n{}", config.withoutPath("password").withoutPath("sun.java.command")
    --- End diff --
    
    Please add comment why we exclude `sun.jaba.command`.


---

[GitHub] drill pull request #1174: DRILL-6250: Sqlline start command with password ap...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/drill/pull/1174


---

[GitHub] drill issue #1174: DRILL-6250: Sqlline start command with password appears i...

Posted by arina-ielchiieva <gi...@git.apache.org>.

Github user arina-ielchiieva commented on the issue:

    https://github.com/apache/drill/pull/1174
  
    +1


---