You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/01/19 07:11:19 UTC

[GitHub] [shardingsphere] sandynz opened a new pull request #14892: Update spring and boot version from version range to fixed version

sandynz opened a new pull request #14892:
URL: https://github.com/apache/shardingsphere/pull/14892


   Fixes #14878.
   
   Purpose:
   - Speedup spring downloading in GitHub CI maven building
   
   Changes proposed in this pull request:
   - Update spring and boot version from version range to fixed version
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz commented on pull request #14892: Update spring and boot version from version range to fixed version

Posted by GitBox <gi...@apache.org>.
sandynz commented on pull request #14892:
URL: https://github.com/apache/shardingsphere/pull/14892#issuecomment-1016150589


   Old versions:
   ```
           <springframework.version>[4.3.6.RELEASE,5.0.0.M1)</springframework.version>
           <spring-boot.version>[1.5.20.RELEASE,2.0.0.M1)</spring-boot.version>
   ```
   
   Desired versions (keep the same versions as example modules):
   ```
           <springframework.version>5.2.19.RELEASE</springframework.version>
           <spring-boot.version>2.0.9.RELEASE</spring-boot.version>
   ```
   But it have several errors in different modules when `mvn install`, so keep the same version branch for now.
   The version is solved by `mvn versions:resolve-ranges`.
   
   Temp versions:
   ```
           <springframework.version>4.3.30.RELEASE</springframework.version>
           <spring-boot.version>1.5.22.RELEASE</spring-boot.version>
   ```
   
   Version upgrading will be done later.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz commented on pull request #14892: Update spring and boot version from version range to fixed version

Posted by GitBox <gi...@apache.org>.
sandynz commented on pull request #14892:
URL: https://github.com/apache/shardingsphere/pull/14892#issuecomment-1016211925


   After some discussion:
   - keep range version is friendly for end users, which means ShardingSphere supports these spring versions
   - when self-hosted runners are ready, it should be faster
   
   So keep the range version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz closed pull request #14892: Update spring and boot version from version range to fixed version

Posted by GitBox <gi...@apache.org>.
sandynz closed pull request #14892:
URL: https://github.com/apache/shardingsphere/pull/14892


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org