You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/17 17:10:34 UTC
[GitHub] [spark] kyoty commented on a change in pull request #32190: [SPARK-35087][UI] Some columns in table Aggregated Metrics by Executor of stage-detail page shows incorrectly.
kyoty commented on a change in pull request #32190:
URL: https://github.com/apache/spark/pull/32190#discussion_r615279038
##########
File path: core/src/main/resources/org/apache/spark/ui/static/stagepage.js
##########
@@ -562,10 +577,16 @@ $(document).ready(function () {
}
],
"columnDefs": [
- { "visible": false, "targets": 15 },
- { "visible": false, "targets": 16 },
- { "visible": false, "targets": 17 },
- { "visible": false, "targets": 18 }
+ // String with structures like : 'bytes / bytes', 'bytes / bytes'
+ // they should be sorted as numerical-order instead of lexicographical-order.
+ { "type": "size", "targets": 9 },
+ { "type": "size", "targets": 10 },
+ { "type": "size", "targets": 11 },
+ { "type": "size", "targets": 12 },
+ { "type": "size", "visible": false, "targets": 15 },
Review comment:
I have modified the detailed description of the reason for the modification.
I only modified the columns corresponding to 9-12 because the true values of these columns are actually strings, while columns 13-18 are all numbers indeed. Therefore, we only focused on columns 9-12 to sort them according to their numerical value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org