You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Alok Lal <al...@hortonworks.com> on 2015/08/05 22:38:20 UTC
Review Request 37140: RANGER-594 Policy Validation: Change the logic
to
generate friendly error messages to be like used for Service and Service def
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37140/
-----------------------------------------------------------
Review request for ranger and Madhan Neethiraj.
Bugs: RANGER-594
https://issues.apache.org/jira/browse/RANGER-594
Repository: ranger
Description
-------
Policy Validation: Change the logic to generate friendly error messages to be like used for Service and Service def
- Changes of interest are in policy vaidation
- Other changes are to remove the code that was put in place in service and serivce-def files as we were trying different approaches on how to do the validation error handing.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java c40efc9
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java 8817049
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefValidator.java 75372c2
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceValidator.java 3cfaa3e
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/ValidationFailureDetails.java 64e7e50
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/ValidationFailureDetailsBuilder.java ab67f1f
agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestValidationFailureDetails.java 815d41c
Diff: https://reviews.apache.org/r/37140/diff/
Testing
-------
existing tests work.
Thanks,
Alok Lal
Re: Review Request 37140: RANGER-594 Policy Validation: Change the
logic to
generate friendly error messages to be like used for Service and Service def
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37140/#review94309
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Aug. 5, 2015, 8:38 p.m., Alok Lal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37140/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2015, 8:38 p.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-594
> https://issues.apache.org/jira/browse/RANGER-594
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Policy Validation: Change the logic to generate friendly error messages to be like used for Service and Service def
> - Changes of interest are in policy vaidation
> - Other changes are to remove the code that was put in place in service and serivce-def files as we were trying different approaches on how to do the validation error handing.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java c40efc9
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java 8817049
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefValidator.java 75372c2
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceValidator.java 3cfaa3e
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/ValidationFailureDetails.java 64e7e50
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/ValidationFailureDetailsBuilder.java ab67f1f
> agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestValidationFailureDetails.java 815d41c
>
> Diff: https://reviews.apache.org/r/37140/diff/
>
>
> Testing
> -------
>
> existing tests work.
>
>
> Thanks,
>
> Alok Lal
>
>