[GitHub] [spark] rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable
URL: https://github.com/apache/spark/pull/24832#discussion_r298257179
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
 ##########
 @@ -274,7 +284,7 @@ class AstBuilder(conf: SQLConf) extends SqlBaseBaseVisitor[AnyRef] with Logging
   override def visitInsertOverwriteTable(
       ctx: InsertOverwriteTableContext): InsertTableParams = withOrigin(ctx) {
     assert(ctx.OVERWRITE() != null)
-    val tableIdent = visitTableIdentifier(ctx.tableIdentifier)
+    val tableIdent = visitMultipartIdentifier(ctx.multipartIdentifier)
 
 Review comment:
   We discussed this in the DSv2 sync last night and decided to add a method to the write builder to pass this `IF NOT EXISTS` flag. This will be done in a follow-up to avoid over-complicating this commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org