You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "nastra (via GitHub)" <gi...@apache.org> on 2024/09/17 08:09:49 UTC
[PR] Core: Add explicit parser for LoadTableResponse [iceberg]
nastra opened a new pull request, #11148:
URL: https://github.com/apache/iceberg/pull/11148
This introduces an explicit JSON parser for `LoadTableResponse` as a preparation step for standardizing credentials as proposed in https://github.com/apache/iceberg/pull/10722.
Currently, `LoadTableResponse` is relying on reflection to properly do JSON <--> `LoadTableResponse`.
Having an explicit JSON parser has the advantage that the underlying `credentials` can be parsed in a way that gives us more flexiblity and allows to be fully forward/backward compatible when new credentials are being added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Add explicit JSON parser for LoadTableResponse [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra merged PR #11148:
URL: https://github.com/apache/iceberg/pull/11148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Add explicit JSON parser for LoadTableResponse [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #11148:
URL: https://github.com/apache/iceberg/pull/11148#discussion_r1764428159
##########
core/src/main/java/org/apache/iceberg/rest/responses/LoadTableResponse.java:
##########
@@ -61,7 +62,12 @@ public String metadataLocation() {
}
public TableMetadata tableMetadata() {
- return TableMetadata.buildFrom(metadata).withMetadataLocation(metadataLocation).build();
+ if (null == metadataWithLocation) {
Review Comment:
we were rebuilding the metadata on every call to `tableMetadata()` which was required when java reflection was used for JSON deserialiazion. However, now this isn't needed anymore, so we can compute the metadata with the location only once
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Add explicit JSON parser for LoadTableResponse [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on PR #11148:
URL: https://github.com/apache/iceberg/pull/11148#issuecomment-2360031810
thanks @amogh-jahagirdar for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org