You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dick Cavender <dc...@pivotal.io> on 2015/11/03 01:24:58 UTC
Re: Review Request 39445: GEODE-12/GEODE-304 Fix Pulse tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39445/#review104832
-----------------------------------------------------------
Ship it!
Ship It!
- Dick Cavender
On Oct. 28, 2015, 4:29 a.m., Nitin Lamba wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39445/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2015, 4:29 a.m.)
>
>
> Review request for geode, Dick Cavender, Tushar Khairnar, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> This includes several clean-ups for Pulse tests including:
> - Build gradle (to invoke the right set of tests)
> - Pulse JMX test beans update based on Geode JMX changes in recent releases
> - Test references (corrected or ignored)
>
> This is set of 3 commits on feature/GEODE-12 branch.
>
>
> Diffs
> -----
>
> pulse/build.gradle b2bd5fc
> pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/data/JMXDataUpdater.java 27aed67
> pulse/src/main/resources/pulse.properties 17299c2
> pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/Member.java 812e055
> pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseAutomatedTests.java 21c14d5
> pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseTestData.java d1a92a2
> pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseTests.java b6dd7c6
> pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/RegionOnMember.java 7402a8b
> pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/ServerObject.java 97acac7
> pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/ServerObjectMBean.java 9487c0e
> pulse/src/test/resources/test.properties fabeea1
>
> Diff: https://reviews.apache.org/r/39445/diff/
>
>
> Testing
> -------
>
> Tested with the latest Firefox browser 41.0.2.
> All UI tests pass.
>
>
> File Attachments
> ----------------
>
> Patch_02 - JUnit & gradle updates
> https://reviews.apache.org/media/uploaded/files/2015/10/28/4a2bf570-14f8-458d-9cc6-529d0f9b8f77__patch_02.diff
> Patch_03 - Test clean-up & fixes
> https://reviews.apache.org/media/uploaded/files/2015/10/28/b5497b9a-8742-46e8-870e-a16e8622cebc__patch_03.diff
>
>
> Thanks,
>
> Nitin Lamba
>
>