You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "XL-Zhao-23 (via GitHub)" <gi...@apache.org> on 2025/12/22 14:13:39 UTC
[PR] Verify the fix for apache/skywalking#13517 [skywalking-banyandb]
XL-Zhao-23 opened a new pull request, #912:
URL: https://github.com/apache/skywalking-banyandb/pull/912
This pull request is created to **verify the resolution of apache/skywalking#13517**.
No functional changes are made; it only contains tests or minimal adjustments to confirm the fix.
- [x] This pull request does **not** introduce any new features or bug fixes.
- [x] CI is expected to pass to ensure the verification is successful.
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#13517.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md) if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Verify the fix for apache/skywalking#13517 [skywalking-banyandb]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #912:
URL: https://github.com/apache/skywalking-banyandb/pull/912#issuecomment-3695203445
changes.md should be updated as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade Node.js support from 20.12 to 24.6.0 [skywalking-banyandb]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #912:
URL: https://github.com/apache/skywalking-banyandb/pull/912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Verify the fix for apache/skywalking#13517 [skywalking-banyandb]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #912:
URL: https://github.com/apache/skywalking-banyandb/pull/912#discussion_r2650313746
##########
CHANGES.md:
##########
@@ -31,6 +31,10 @@ Release Notes.
- Add FODC overview doc.
- Remove Java client doc, and recreate client APIs docs.
+### Chores
+
+- Upgrade Node.js support from 20.12 to 24.6.0, and align CI, license checks, and documentation
Review Comment:
There is an extra space at the beginning of this line before "Upgrade". This is inconsistent with the formatting of other entries in the CHANGES.md file. The line should start with a single hyphen followed by two spaces, then the text.
```suggestion
- Upgrade Node.js support from 20.12 to 24.6.0, and align CI, license checks, and documentation
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Verify the fix for apache/skywalking#13517 [skywalking-banyandb]
Posted by "XL-Zhao-23 (via GitHub)" <gi...@apache.org>.
XL-Zhao-23 closed pull request #912: Verify the fix for apache/skywalking#13517
URL: https://github.com/apache/skywalking-banyandb/pull/912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Verify the fix for apache/skywalking#13517 [skywalking-banyandb]
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily commented on code in PR #912:
URL: https://github.com/apache/skywalking-banyandb/pull/912#discussion_r2642165905
##########
.licenserc.yaml:
##########
@@ -82,7 +82,9 @@ header: # `header` section is configurations for source codes license header.
- '**/.gitignore'
- '**/buf.lock'
- '**/ginkgo.report'
- - 'ui'
Review Comment:
UI uses the `ui/.licenserc.yaml` to check headers. Please revert your changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Verify the fix for apache/skywalking#13517 [skywalking-banyandb]
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily commented on PR #912:
URL: https://github.com/apache/skywalking-banyandb/pull/912#issuecomment-3695201263
> @Fine0830 @hanahmily It seems we don't need to upgrade dependency for Node24. Please review. BTW, which compiling docs we should consider to update?
@XL-Zhao-23 Please update references of the Node's version in `CONTRIBUTING.md` and `binaries.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Verify the fix for apache/skywalking#13517 [skywalking-banyandb]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #912:
URL: https://github.com/apache/skywalking-banyandb/pull/912#issuecomment-3694306182
@Fine0830 @hanahmily It seems we don't need to upgrade dependency for Node24. Please review.
BTW, which compiling docs we should consider to update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Verify the fix for apache/skywalking#13517 [skywalking-banyandb]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #912:
URL: https://github.com/apache/skywalking-banyandb/pull/912#issuecomment-3693567131
You seem to be able to change the main compiling to Node24 directly.
I think we don't need to add a new CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Verify the fix for apache/skywalking#13517 [skywalking-banyandb]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #912:
URL: https://github.com/apache/skywalking-banyandb/pull/912#issuecomment-3693832535
Yes. If it is too complex for you, it's fine. We will do that later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Verify the fix for apache/skywalking#13517 [skywalking-banyandb]
Posted by "XL-Zhao-23 (via GitHub)" <gi...@apache.org>.
XL-Zhao-23 commented on PR #912:
URL: https://github.com/apache/skywalking-banyandb/pull/912#issuecomment-3693813195
I am a backend developer and have limited experience with frontend development, so I would like to clarify whether “change the main compiling to Node 24 directly” also implies updating the Node.js version in the CI configuration, as well as updating the package.json files in both the mcp and ui projects (i.e., engines.node and @types/node).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Verify the fix for apache/skywalking#13517 [skywalking-banyandb]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #912:
URL: https://github.com/apache/skywalking-banyandb/pull/912#discussion_r2649387835
##########
Makefile:
##########
@@ -225,4 +225,4 @@ release-push-candidate: ## Push release candidate
.PHONY: test test-race test-coverage test-ci test-docker
.PHONY: license-check license-fix license-dep
.PHONY: release release-binary release-source release-sign release-assembly
-.PHONY: vendor-update
+.PHONY: vendor-update
Review Comment:
Trailing whitespace has been added to this line. This should be removed to maintain consistent formatting and avoid potential issues with version control systems that flag trailing whitespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Verify the fix for apache/skywalking#13517 [skywalking-banyandb]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #912:
URL: https://github.com/apache/skywalking-banyandb/pull/912#issuecomment-3685309768
## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/912?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 32.15%. Comparing base ([`3530dd9`](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/3530dd9b5cefaa4fef60eec91ecbfbdfcaf243c5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a5cd5b8`](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/a5cd5b89e691ea48b5e08fc0cd6c08722e8ad64d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 86 commits behind head on main.
> :exclamation: There is a different number of reports uploaded between BASE (3530dd9) and HEAD (a5cd5b8). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (3530dd9) | HEAD (a5cd5b8) |
>|------|------|------|
>||1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #912 +/- ##
===========================================
- Coverage 45.97% 32.15% -13.83%
===========================================
Files 328 125 -203
Lines 55505 12825 -42680
===========================================
- Hits 25520 4124 -21396
+ Misses 27909 8341 -19568
+ Partials 2076 360 -1716
```
| [Flag](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/912/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [fodc](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/912/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.65% <ø> (?)` | |
| [pkg](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/912/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `29.07% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/912?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Verify the fix for apache/skywalking#13517 [skywalking-banyandb]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #912:
URL: https://github.com/apache/skywalking-banyandb/pull/912#issuecomment-3682281329
With the update, CI check could fail. Please udpate and fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Verify the fix for apache/skywalking#13517 [skywalking-banyandb]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #912:
URL: https://github.com/apache/skywalking-banyandb/pull/912#issuecomment-3685448997
@XL-Zhao-23 I made a mistake and misguided you. This skywalking-eyes bug only exist when we try to bump up the UI to Node24(currently in Node20). So, currently, you just need to upgrade the eyes version, and if we want to verify that, we have to bump up Node version with dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Verify the fix for apache/skywalking#13517 [skywalking-banyandb]
Posted by "XL-Zhao-23 (via GitHub)" <gi...@apache.org>.
XL-Zhao-23 commented on PR #912:
URL: https://github.com/apache/skywalking-banyandb/pull/912#issuecomment-3685606396
Thanks for the clarification! I understand now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org