You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/07/02 06:17:15 UTC

[GitHub] [iceberg] ismailsimsek commented on pull request #2778: Core: Fix JdbcCatalog CATALOG_TABLE_NAME to lowercase

ismailsimsek commented on pull request #2778:
URL: https://github.com/apache/iceberg/pull/2778#issuecomment-872746858


   looks good, do you want o add second fix too ? 
   changing varchar size like below? 
   
   ```
         "CREATE TABLE " + CATALOG_TABLE_NAME +
             "(" +
             CATALOG_NAME + " VARCHAR(255) NOT NULL," +
             TABLE_NAMESPACE + " VARCHAR(255) NOT NULL," +
             TABLE_NAME + " VARCHAR(255) NOT NULL," +
             METADATA_LOCATION + " VARCHAR(5500)," +
             PREVIOUS_METADATA_LOCATION + " VARCHAR(5500)," +
             "PRIMARY KEY (" + CATALOG_NAME + ", " + TABLE_NAMESPACE + ", " + TABLE_NAME + ")" +
             ")";
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org