You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "ajantha-bhat (via GitHub)" <gi...@apache.org> on 2024/10/29 12:54:41 UTC
[PR] open-api: Fix testFixtures dependencies [iceberg]
ajantha-bhat opened a new pull request, #11422:
URL: https://github.com/apache/iceberg/pull/11422
Importing
`testFixturesImplementation project(':iceberg-core').sourceSets.test.runtimeClasspath`
brings everything to class path and creates problem for shadow jar.
Need to depend only on required classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] open-api: Fix testFixtures dependencies [iceberg]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #11422:
URL: https://github.com/apache/iceberg/pull/11422#issuecomment-2445022155
@ajantha-bhat Great catch, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] open-api: Fix testFixtures dependencies [iceberg]
Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on code in PR #11422:
URL: https://github.com/apache/iceberg/pull/11422#discussion_r1820742624
##########
build.gradle:
##########
@@ -973,10 +973,28 @@ project(':iceberg-open-api') {
testFixturesImplementation project(':iceberg-api')
testFixturesImplementation project(':iceberg-core')
testFixturesImplementation project(path: ':iceberg-core', configuration: 'testArtifacts')
- testFixturesImplementation project(':iceberg-core').sourceSets.test.runtimeClasspath
testFixturesImplementation project(':iceberg-aws')
testFixturesImplementation project(':iceberg-gcp')
testFixturesImplementation project(':iceberg-azure')
+ testFixturesImplementation(libs.hadoop3.common) {
+ exclude group: 'log4j'
+ exclude group: 'org.slf4j'
+ exclude group: 'ch.qos.reload4j'
+ exclude group: 'org.apache.avro', module: 'avro'
+ exclude group: 'com.fasterxml.woodstox'
+ exclude group: 'com.google.guava'
+ exclude group: 'com.google.protobuf'
+ exclude group: 'org.apache.curator'
+ exclude group: 'org.apache.zookeeper'
+ exclude group: 'org.apache.kerby'
+ exclude group: 'org.apache.hadoop', module: 'hadoop-auth'
+ exclude group: 'org.apache.commons', module: 'commons-configuration2'
+ exclude group: 'org.apache.hadoop.thirdparty', module: 'hadoop-shaded-protobuf_3_7'
+ exclude group: 'org.codehaus.woodstox'
+ exclude group: 'org.eclipse.jetty'
+ }
+ testFixturesImplementation project(path: ':iceberg-bundled-guava', configuration: 'shadow')
Review Comment:
Needed as we are using `Maps` from Guava.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] open-api: Fix testFixtures dependencies [iceberg]
Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on code in PR #11422:
URL: https://github.com/apache/iceberg/pull/11422#discussion_r1820745009
##########
build.gradle:
##########
@@ -973,10 +973,28 @@ project(':iceberg-open-api') {
testFixturesImplementation project(':iceberg-api')
testFixturesImplementation project(':iceberg-core')
testFixturesImplementation project(path: ':iceberg-core', configuration: 'testArtifacts')
- testFixturesImplementation project(':iceberg-core').sourceSets.test.runtimeClasspath
Review Comment:
This brings too many things from test runtime class path and creates a problem for shadow jar. For example it brings some csv files, GPL license file etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] open-api: Fix testFixtures dependencies [iceberg]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #11422:
URL: https://github.com/apache/iceberg/pull/11422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] open-api: Fix testFixtures dependencies [iceberg]
Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on code in PR #11422:
URL: https://github.com/apache/iceberg/pull/11422#discussion_r1820741909
##########
build.gradle:
##########
@@ -973,10 +973,28 @@ project(':iceberg-open-api') {
testFixturesImplementation project(':iceberg-api')
testFixturesImplementation project(':iceberg-core')
testFixturesImplementation project(path: ':iceberg-core', configuration: 'testArtifacts')
- testFixturesImplementation project(':iceberg-core').sourceSets.test.runtimeClasspath
testFixturesImplementation project(':iceberg-aws')
testFixturesImplementation project(':iceberg-gcp')
testFixturesImplementation project(':iceberg-azure')
+ testFixturesImplementation(libs.hadoop3.common) {
+ exclude group: 'log4j'
Review Comment:
exclusion copied from other modules.
Needed hadoop dependency for `Configuration` class in `RCKUtils`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] open-api: Fix testFixtures dependencies [iceberg]
Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on code in PR #11422:
URL: https://github.com/apache/iceberg/pull/11422#discussion_r1820743221
##########
build.gradle:
##########
@@ -973,10 +973,28 @@ project(':iceberg-open-api') {
testFixturesImplementation project(':iceberg-api')
testFixturesImplementation project(':iceberg-core')
testFixturesImplementation project(path: ':iceberg-core', configuration: 'testArtifacts')
- testFixturesImplementation project(':iceberg-core').sourceSets.test.runtimeClasspath
testFixturesImplementation project(':iceberg-aws')
testFixturesImplementation project(':iceberg-gcp')
testFixturesImplementation project(':iceberg-azure')
+ testFixturesImplementation(libs.hadoop3.common) {
+ exclude group: 'log4j'
+ exclude group: 'org.slf4j'
+ exclude group: 'ch.qos.reload4j'
+ exclude group: 'org.apache.avro', module: 'avro'
+ exclude group: 'com.fasterxml.woodstox'
+ exclude group: 'com.google.guava'
+ exclude group: 'com.google.protobuf'
+ exclude group: 'org.apache.curator'
+ exclude group: 'org.apache.zookeeper'
+ exclude group: 'org.apache.kerby'
+ exclude group: 'org.apache.hadoop', module: 'hadoop-auth'
+ exclude group: 'org.apache.commons', module: 'commons-configuration2'
+ exclude group: 'org.apache.hadoop.thirdparty', module: 'hadoop-shaded-protobuf_3_7'
+ exclude group: 'org.codehaus.woodstox'
+ exclude group: 'org.eclipse.jetty'
+ }
+ testFixturesImplementation project(path: ':iceberg-bundled-guava', configuration: 'shadow')
+ testFixturesImplementation libs.junit.jupiter
Review Comment:
Junit dependency was previously coming from core runtime path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org