You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/01/15 06:44:27 UTC
[GitHub] [shardingsphere] dmsolr opened a new pull request #9045: delete duplication codes
dmsolr opened a new pull request #9045:
URL: https://github.com/apache/shardingsphere/pull/9045
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
-
-
-
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #9045: delete duplication codes
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9045:
URL: https://github.com/apache/shardingsphere/pull/9045#issuecomment-760712213
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9045?src=pr&el=h1) Report
> Merging [#9045](https://codecov.io/gh/apache/shardingsphere/pull/9045?src=pr&el=desc) (b558187) into [master](https://codecov.io/gh/apache/shardingsphere/commit/3d21ffcaa4b7aeb854496c403f46c0aa4ee6d611?el=desc) (3d21ffc) will **decrease** coverage by `0.14%`.
> The diff coverage is `96.66%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/9045?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9045 +/- ##
============================================
- Coverage 69.86% 69.71% -0.15%
+ Complexity 658 654 -4
============================================
Files 1639 1635 -4
Lines 26491 26460 -31
Branches 4607 4614 +7
============================================
- Hits 18507 18446 -61
- Misses 6718 6749 +31
+ Partials 1266 1265 -1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/9045?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ing/opentracing/constant/OpenTracingConstants.java](https://codecov.io/gh/apache/shardingsphere/pull/9045/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtcGx1Z2lucy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1wbHVnaW4tdHJhY2luZy9zaGFyZGluZ3NwaGVyZS1hZ2VudC10cmFjaW5nLW9wZW50cmFjaW5nL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9wbHVnaW4vdHJhY2luZy9vcGVudHJhY2luZy9jb25zdGFudC9PcGVuVHJhY2luZ0NvbnN0YW50cy5qYXZh) | `40.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...eger/definition/JaegerPluginDefinitionService.java](https://codecov.io/gh/apache/shardingsphere/pull/9045/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtcGx1Z2lucy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1wbHVnaW4tdHJhY2luZy9zaGFyZGluZ3NwaGVyZS1hZ2VudC10cmFjaW5nLWphZWdlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvcGx1Z2luL3RyYWNpbmcvamFlZ2VyL2RlZmluaXRpb24vSmFlZ2VyUGx1Z2luRGVmaW5pdGlvblNlcnZpY2UuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (-1.00)` | |
| [.../opentracing/advice/CommandExecutorTaskAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/9045/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtcGx1Z2lucy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1wbHVnaW4tdHJhY2luZy9zaGFyZGluZ3NwaGVyZS1hZ2VudC10cmFjaW5nLW9wZW50cmFjaW5nL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9wbHVnaW4vdHJhY2luZy9vcGVudHJhY2luZy9hZHZpY2UvQ29tbWFuZEV4ZWN1dG9yVGFza0FkdmljZS5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...opentracing/advice/JDBCExecutorCallbackAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/9045/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtcGx1Z2lucy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1wbHVnaW4tdHJhY2luZy9zaGFyZGluZ3NwaGVyZS1hZ2VudC10cmFjaW5nLW9wZW50cmFjaW5nL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9wbHVnaW4vdHJhY2luZy9vcGVudHJhY2luZy9hZHZpY2UvSkRCQ0V4ZWN1dG9yQ2FsbGJhY2tBZHZpY2UuamF2YQ==) | `92.00% <100.00%> (+2.52%)` | `1.00 <0.00> (ø)` | |
| [...cing/opentracing/advice/SQLParserEngineAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/9045/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtcGx1Z2lucy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1wbHVnaW4tdHJhY2luZy9zaGFyZGluZ3NwaGVyZS1hZ2VudC10cmFjaW5nLW9wZW50cmFjaW5nL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9wbHVnaW4vdHJhY2luZy9vcGVudHJhY2luZy9hZHZpY2UvU1FMUGFyc2VyRW5naW5lQWR2aWNlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...tracing/opentracing/span/OpenTracingErrorSpan.java](https://codecov.io/gh/apache/shardingsphere/pull/9045/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtcGx1Z2lucy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1wbHVnaW4tdHJhY2luZy9zaGFyZGluZ3NwaGVyZS1hZ2VudC10cmFjaW5nLW9wZW50cmFjaW5nL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9wbHVnaW4vdHJhY2luZy9vcGVudHJhY2luZy9zcGFuL09wZW5UcmFjaW5nRXJyb3JTcGFuLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...end/text/distsql/rql/RQLBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/9045/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcnFsL1JRTEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh) | `27.27% <0.00%> (-32.73%)` | `0.00% <0.00%> (ø%)` | |
| [.../rql/impl/ReplicaQueryRuleQueryBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/9045/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcnFsL2ltcGwvUmVwbGljYVF1ZXJ5UnVsZVF1ZXJ5QmFja2VuZEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...jaeger/service/JaegerTracingPluginBootService.java](https://codecov.io/gh/apache/shardingsphere/pull/9045/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtcGx1Z2lucy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1wbHVnaW4tdHJhY2luZy9zaGFyZGluZ3NwaGVyZS1hZ2VudC10cmFjaW5nLWphZWdlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvcGx1Z2luL3RyYWNpbmcvamFlZ2VyL3NlcnZpY2UvSmFlZ2VyVHJhY2luZ1BsdWdpbkJvb3RTZXJ2aWNlLmphdmE=) | `78.94% <0.00%> (+5.26%)` | `1.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9045?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9045?src=pr&el=footer). Last update [3d21ffc...b558187](https://codecov.io/gh/apache/shardingsphere/pull/9045?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] yu199195 closed pull request #9045: delete duplication codes
Posted by GitBox <gi...@apache.org>.
yu199195 closed pull request #9045:
URL: https://github.com/apache/shardingsphere/pull/9045
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org