You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "slowpao (via GitHub)" <gi...@apache.org> on 2023/02/20 11:22:17 UTC
[GitHub] [incubator-eventmesh] slowpao opened a new pull request, #3219: [ISSUE apache#3181] add aclProperties Object
slowpao opened a new pull request, #3219:
URL: https://github.com/apache/incubator-eventmesh/pull/3219
The AclService interface has been modified so that its methods can receive custom objects
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] slowpao commented on a diff in pull request #3219: [ISSUE #3181] add aclProperties Object
Posted by "slowpao (via GitHub)" <gi...@apache.org>.
slowpao commented on code in PR #3219:
URL: https://github.com/apache/incubator-eventmesh/pull/3219#discussion_r1112483520
##########
eventmesh-security-plugin/eventmesh-security-api/src/main/java/org/apache/eventmesh/api/acl/AclProperties.java:
##########
@@ -0,0 +1,105 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.eventmesh.api.acl;
+
+import java.util.concurrent.ConcurrentHashMap;
+
+public class AclProperties {
+
+ private String clientIp;
+ private String user;
+ private String pwd;
+ private String subsystem;
+ private String topic;
+ private Integer requestCode;
+ private String requestURI;
+ private String token;
+ private ConcurrentHashMap<String, Object> extendedField;
Review Comment:
Yes, I would resubmit the extension method for manipulating map
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] slowpao closed pull request #3219: [ISSUE #3181] add aclProperties Object
Posted by "slowpao (via GitHub)" <gi...@apache.org>.
slowpao closed pull request #3219: [ISSUE #3181] add aclProperties Object
URL: https://github.com/apache/incubator-eventmesh/pull/3219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #3219: [ISSUE #3181] add aclProperties Object
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3219:
URL: https://github.com/apache/incubator-eventmesh/pull/3219#issuecomment-1437234372
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/3219?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3219](https://codecov.io/gh/apache/incubator-eventmesh/pull/3219?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9832e00) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/b5eb2792513290adb2bd391f92b619137aaacbc7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b5eb279) will **decrease** coverage by `0.03%`.
> The diff coverage is `2.00%`.
> :exclamation: Current head 9832e00 differs from pull request most recent head 39cd7cc. Consider uploading reports for the commit 39cd7cc to get more accurate results
```diff
@@ Coverage Diff @@
## master #3219 +/- ##
============================================
- Coverage 13.05% 13.03% -0.03%
- Complexity 1154 1155 +1
============================================
Files 548 549 +1
Lines 28703 28728 +25
Branches 2848 2845 -3
============================================
- Hits 3747 3744 -3
- Misses 24633 24660 +27
- Partials 323 324 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/3219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../eventmesh/common/config/convert/ConvertValue.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9jb25maWcvY29udmVydC9Db252ZXJ0VmFsdWUuamF2YQ==) | `60.00% <0.00%> (ø)` | |
| [...ain/java/org/apache/eventmesh/runtime/acl/Acl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FjbC9BY2wuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../org/apache/eventmesh/acl/impl/AclServiceImpl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXNlY3VyaXR5LXBsdWdpbi9ldmVudG1lc2gtc2VjdXJpdHktYWNsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvYWNsL2ltcGwvQWNsU2VydmljZUltcGwuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...va/org/apache/eventmesh/api/acl/AclProperties.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXNlY3VyaXR5LXBsdWdpbi9ldmVudG1lc2gtc2VjdXJpdHktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvYXBpL2FjbC9BY2xQcm9wZXJ0aWVzLmphdmE=) | `3.57% <3.57%> (ø)` | |
| [.../admin/handler/QueryRecommendEventMeshHandler.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvUXVlcnlSZWNvbW1lbmRFdmVudE1lc2hIYW5kbGVyLmphdmE=) | `88.88% <0.00%> (-3.71%)` | :arrow_down: |
| [...ventmesh/client/grpc/util/EventMeshClientUtil.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L2dycGMvdXRpbC9FdmVudE1lc2hDbGllbnRVdGlsLmphdmE=) | `90.00% <0.00%> (-1.54%)` | :arrow_down: |
| [.../trace/pinpoint/exporter/PinpointSpanExporter.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXRyYWNlLXBsdWdpbi9ldmVudG1lc2gtdHJhY2UtcGlucG9pbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC90cmFjZS9waW5wb2ludC9leHBvcnRlci9QaW5wb2ludFNwYW5FeHBvcnRlci5qYXZh) | `68.45% <0.00%> (-0.68%)` | :arrow_down: |
| [...untime/core/protocol/http/push/HTTPClientPool.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wdXNoL0hUVFBDbGllbnRQb29sLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...otocol/meshmessage/MeshMessageProtocolAdaptor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXByb3RvY29sLXBsdWdpbi9ldmVudG1lc2gtcHJvdG9jb2wtbWVzaG1lc3NhZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9wcm90b2NvbC9tZXNobWVzc2FnZS9NZXNoTWVzc2FnZVByb3RvY29sQWRhcHRvci5qYXZh) | `3.84% <0.00%> (+0.07%)` | :arrow_up: |
| [.../apache/eventmesh/common/config/ConfigService.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9jb25maWcvQ29uZmlnU2VydmljZS5qYXZh) | `45.00% <0.00%> (+0.55%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on a diff in pull request #3219: [ISSUE #3181] add aclProperties Object
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 commented on code in PR #3219:
URL: https://github.com/apache/incubator-eventmesh/pull/3219#discussion_r1112461043
##########
eventmesh-security-plugin/eventmesh-security-api/src/main/java/org/apache/eventmesh/api/acl/AclProperties.java:
##########
@@ -0,0 +1,105 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.eventmesh.api.acl;
+
+import java.util.concurrent.ConcurrentHashMap;
+
+public class AclProperties {
+
+ private String clientIp;
+ private String user;
+ private String pwd;
+ private String subsystem;
+ private String topic;
+ private Integer requestCode;
+ private String requestURI;
+ private String token;
+ private ConcurrentHashMap<String, Object> extendedField;
Review Comment:
Add this map field, but never set/get the map in this pull request, perhaps you need also expand the interface or method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org