You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/07/17 04:40:46 UTC

[GitHub] [samza] atoomula commented on a change in pull request #1401: SAMZA-2560: Generate SamzaSQLRelRecord using avro schema of input event instead of cached-schema.

atoomula commented on a change in pull request #1401:
URL: https://github.com/apache/samza/pull/1401#discussion_r456214376



##########
File path: samza-sql/src/main/java/org/apache/samza/sql/interfaces/SqlIOConfig.java
##########
@@ -81,11 +81,13 @@ public SqlIOConfig(String systemName, String streamName, List<String> sourcePart
     this.streamId = String.format("%s-%s", systemName, streamName);
 
     samzaRelConverterName = streamConfigs.get(CFG_SAMZA_REL_CONVERTER);
-    Validate.notEmpty(samzaRelConverterName, String.format("System %s is not supported. Please check if the system name is provided correctly.", systemName));

Review comment:
       Can you revert the change for validation here and below ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org