[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33962: [SPARK-36719][CORE] Supporting Netty Logging at the network layer

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #33962:
URL: https://github.com/apache/spark/pull/33962#discussion_r706328737



##########
File path: common/network-common/src/main/java/org/apache/spark/network/TransportContext.java
##########
@@ -187,7 +190,11 @@ public TransportChannelHandler initializePipeline(
       RpcHandler channelRpcHandler) {
     try {
       TransportChannelHandler channelHandler = createChannelHandler(channel, channelRpcHandler);
-      ChannelPipeline pipeline = channel.pipeline()
+      ChannelPipeline pipeline = channel.pipeline();
+      if (nettyLogger.getLoggingHandler() != null) {

Review comment:
       When does this become `null`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org