You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Christoph Lenggenhager (JIRA)" <ji...@apache.org> on 2013/01/22 17:24:12 UTC

[jira] [Created] (WW-3973) WW-3866 overrides ParameterNameAware decision with interceptor settings

Christoph Lenggenhager created WW-3973:
------------------------------------------

             Summary: WW-3866 overrides ParameterNameAware decision with interceptor settings
                 Key: WW-3973
                 URL: https://issues.apache.org/jira/browse/WW-3973
             Project: Struts 2
          Issue Type: Bug
    Affects Versions: 2.3.7
            Reporter: Christoph Lenggenhager


The fix for WW-3866 (Revision 1379386) changes the logic for acceptable parameter names from

{code:title=com.opensymphony.xwork2.interceptor.ParametersInterceptor, line 282ff.}
        boolean acceptableName = acceptableName(name)
                 && (parameterNameAware == null || parameterNameAware.acceptableParameterName(name));
{code}

to

{code:title=com.opensymphony.xwork2.interceptor.ParametersInterceptor, line 282ff.}
        boolean acceptableName = acceptableName(name)
                 || (parameterNameAware != null && parameterNameAware.acceptableParameterName(name));
{code}

This might impose a security risk if implementations relied on their actions for parameter name validation (e.g. by explicitly whitelisting parameters).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira