You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/07/08 08:15:23 UTC
[GitHub] [cordova-plugin-inappbrowser] BrandOuellette commented on a change
in pull request #363: (iOS & Android) add request headers support
BrandOuellette commented on a change in pull request #363: (iOS & Android) add request headers support
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/363#discussion_r300970979
##########
File path: www/inappbrowser.js
##########
@@ -115,10 +115,29 @@
var cb = function (eventname) {
iab._eventHandler(eventname);
};
-
+ var strWindowHeaders = '';
+ if (windowHeaders) {
+ if (typeof windowHeaders === 'string' || windowHeaders instanceof String) {
+ strWindowHeaders = windowHeaders.replace(/@/gi, '@a');
Review comment:
The re-replacing is probably meant to keep the headers from being parsed as separate options in the options string.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org