You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Chinna Rao Lalam (JIRA)" <ji...@apache.org> on 2011/06/06 15:08:59 UTC

[jira] [Created] (HIVE-2198) While using Hive in server mode, HiveConnection.close() is not cleaning up server side resources

While using Hive in server mode, HiveConnection.close() is not cleaning up server side resources
------------------------------------------------------------------------------------------------

                 Key: HIVE-2198
                 URL: https://issues.apache.org/jira/browse/HIVE-2198
             Project: Hive
          Issue Type: Bug
          Components: Server Infrastructure
    Affects Versions: 0.5.0, 0.8.0
         Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
            Reporter: Chinna Rao Lalam
            Assignee: Chinna Rao Lalam


org.apache.hadoop.hive.service.ThriftHive.Client.clean() method is called for every session end in CLI mode for the cleanup but in HiveServer mode this is not called.
So this can be integrate with the HiveConnection.close()

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-2198) While using Hive in server mode, HiveConnection.close() is not cleaning up server side resources

Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067639#comment-13067639 ] 

Chinna Rao Lalam commented on HIVE-2198:
----------------------------------------

Fixed the indentation

> While using Hive in server mode, HiveConnection.close() is not cleaning up server side resources
> ------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2198
>                 URL: https://issues.apache.org/jira/browse/HIVE-2198
>             Project: Hive
>          Issue Type: Bug
>          Components: Server Infrastructure
>    Affects Versions: 0.5.0, 0.8.0
>         Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
>            Reporter: Chinna Rao Lalam
>            Assignee: Chinna Rao Lalam
>         Attachments: HIVE-2198.1.patch, HIVE-2198.patch
>
>
> org.apache.hadoop.hive.service.ThriftHive.Client.clean() method is called for every session end in CLI mode for the cleanup but in HiveServer mode this is not called.
> So this can be integrate with the HiveConnection.close()

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2198) While using Hive in server mode, HiveConnection.close() is not cleaning up server side resources

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068042#comment-13068042 ] 

John Sichi commented on HIVE-2198:
----------------------------------

+1.  Will commit when tests pass.


> While using Hive in server mode, HiveConnection.close() is not cleaning up server side resources
> ------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2198
>                 URL: https://issues.apache.org/jira/browse/HIVE-2198
>             Project: Hive
>          Issue Type: Bug
>          Components: Server Infrastructure
>    Affects Versions: 0.5.0, 0.8.0
>         Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
>            Reporter: Chinna Rao Lalam
>            Assignee: Chinna Rao Lalam
>         Attachments: HIVE-2198.1.patch, HIVE-2198.patch
>
>
> org.apache.hadoop.hive.service.ThriftHive.Client.clean() method is called for every session end in CLI mode for the cleanup but in HiveServer mode this is not called.
> So this can be integrate with the HiveConnection.close()

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2198) While using Hive in server mode, HiveConnection.close() is not cleaning up server side resources

Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063348#comment-13063348 ] 

Chinna Rao Lalam commented on HIVE-2198:
----------------------------------------

In HiveConnection.close() called client.clean() method for cleanup in server side.

> While using Hive in server mode, HiveConnection.close() is not cleaning up server side resources
> ------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2198
>                 URL: https://issues.apache.org/jira/browse/HIVE-2198
>             Project: Hive
>          Issue Type: Bug
>          Components: Server Infrastructure
>    Affects Versions: 0.5.0, 0.8.0
>         Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
>            Reporter: Chinna Rao Lalam
>            Assignee: Chinna Rao Lalam
>         Attachments: HIVE-2198.patch
>
>
> org.apache.hadoop.hive.service.ThriftHive.Client.clean() method is called for every session end in CLI mode for the cleanup but in HiveServer mode this is not called.
> So this can be integrate with the HiveConnection.close()

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2198) While using Hive in server mode, HiveConnection.close() is not cleaning up server side resources

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068156#comment-13068156 ] 

Hudson commented on HIVE-2198:
------------------------------

Integrated in Hive-trunk-h0.21 #835 (See [https://builds.apache.org/job/Hive-trunk-h0.21/835/])
    HIVE-2198. While using Hive in server mode, HiveConnection.close() is
not cleaning up server side resources
(Chinna Rao Lalam via jvs)

jvs : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148622
Files : 
* /hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java
* /hive/trunk/service/src/test/org/apache/hadoop/hive/service/TestHiveServer.java


> While using Hive in server mode, HiveConnection.close() is not cleaning up server side resources
> ------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2198
>                 URL: https://issues.apache.org/jira/browse/HIVE-2198
>             Project: Hive
>          Issue Type: Bug
>          Components: Server Infrastructure
>    Affects Versions: 0.5.0, 0.8.0
>         Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
>            Reporter: Chinna Rao Lalam
>            Assignee: Chinna Rao Lalam
>             Fix For: 0.8.0
>
>         Attachments: HIVE-2198.1.patch, HIVE-2198.patch
>
>
> org.apache.hadoop.hive.service.ThriftHive.Client.clean() method is called for every session end in CLI mode for the cleanup but in HiveServer mode this is not called.
> So this can be integrate with the HiveConnection.close()

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2198) While using Hive in server mode, HiveConnection.close() is not cleaning up server side resources

Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chinna Rao Lalam updated HIVE-2198:
-----------------------------------

    Status: Patch Available  (was: Open)

> While using Hive in server mode, HiveConnection.close() is not cleaning up server side resources
> ------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2198
>                 URL: https://issues.apache.org/jira/browse/HIVE-2198
>             Project: Hive
>          Issue Type: Bug
>          Components: Server Infrastructure
>    Affects Versions: 0.5.0, 0.8.0
>         Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
>            Reporter: Chinna Rao Lalam
>            Assignee: Chinna Rao Lalam
>         Attachments: HIVE-2198.1.patch, HIVE-2198.patch
>
>
> org.apache.hadoop.hive.service.ThriftHive.Client.clean() method is called for every session end in CLI mode for the cleanup but in HiveServer mode this is not called.
> So this can be integrate with the HiveConnection.close()

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2198) While using Hive in server mode, HiveConnection.close() is not cleaning up server side resources

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063528#comment-13063528 ] 

John Sichi commented on HIVE-2198:
----------------------------------

Chinna, can you also open Review Board requests (reviews.apache.org) as part of submitting each patch?

> While using Hive in server mode, HiveConnection.close() is not cleaning up server side resources
> ------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2198
>                 URL: https://issues.apache.org/jira/browse/HIVE-2198
>             Project: Hive
>          Issue Type: Bug
>          Components: Server Infrastructure
>    Affects Versions: 0.5.0, 0.8.0
>         Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
>            Reporter: Chinna Rao Lalam
>            Assignee: Chinna Rao Lalam
>         Attachments: HIVE-2198.patch
>
>
> org.apache.hadoop.hive.service.ThriftHive.Client.clean() method is called for every session end in CLI mode for the cleanup but in HiveServer mode this is not called.
> So this can be integrate with the HiveConnection.close()

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2198) While using Hive in server mode, HiveConnection.close() is not cleaning up server side resources

Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chinna Rao Lalam updated HIVE-2198:
-----------------------------------

    Attachment: HIVE-2198.patch

> While using Hive in server mode, HiveConnection.close() is not cleaning up server side resources
> ------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2198
>                 URL: https://issues.apache.org/jira/browse/HIVE-2198
>             Project: Hive
>          Issue Type: Bug
>          Components: Server Infrastructure
>    Affects Versions: 0.5.0, 0.8.0
>         Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
>            Reporter: Chinna Rao Lalam
>            Assignee: Chinna Rao Lalam
>         Attachments: HIVE-2198.patch
>
>
> org.apache.hadoop.hive.service.ThriftHive.Client.clean() method is called for every session end in CLI mode for the cleanup but in HiveServer mode this is not called.
> So this can be integrate with the HiveConnection.close()

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-2198) While using Hive in server mode, HiveConnection.close() is not cleaning up server side resources

Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063919#comment-13063919 ] 

jiraposter@reviews.apache.org commented on HIVE-2198:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1089/
-----------------------------------------------------------

Review request for hive and John Sichi.


Summary
-------

In HiveConnection.close() called client.clean() method for cleanup in server side.


This addresses bug HIVE-2198.
    https://issues.apache.org/jira/browse/HIVE-2198


Diffs
-----

  trunk/service/src/test/org/apache/hadoop/hive/service/TestHiveServer.java 1132918 
  trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java 1132918 

Diff: https://reviews.apache.org/r/1089/diff


Testing
-------

Ran all the testcases


Thanks,

chinna



> While using Hive in server mode, HiveConnection.close() is not cleaning up server side resources
> ------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2198
>                 URL: https://issues.apache.org/jira/browse/HIVE-2198
>             Project: Hive
>          Issue Type: Bug
>          Components: Server Infrastructure
>    Affects Versions: 0.5.0, 0.8.0
>         Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
>            Reporter: Chinna Rao Lalam
>            Assignee: Chinna Rao Lalam
>         Attachments: HIVE-2198.patch
>
>
> org.apache.hadoop.hive.service.ThriftHive.Client.clean() method is called for every session end in CLI mode for the cleanup but in HiveServer mode this is not called.
> So this can be integrate with the HiveConnection.close()

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2198) While using Hive in server mode, HiveConnection.close() is not cleaning up server side resources

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Sichi updated HIVE-2198:
-----------------------------

       Resolution: Fixed
    Fix Version/s: 0.8.0
     Hadoop Flags: [Reviewed]
           Status: Resolved  (was: Patch Available)

Committed.  Thanks Chinna!


> While using Hive in server mode, HiveConnection.close() is not cleaning up server side resources
> ------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2198
>                 URL: https://issues.apache.org/jira/browse/HIVE-2198
>             Project: Hive
>          Issue Type: Bug
>          Components: Server Infrastructure
>    Affects Versions: 0.5.0, 0.8.0
>         Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
>            Reporter: Chinna Rao Lalam
>            Assignee: Chinna Rao Lalam
>             Fix For: 0.8.0
>
>         Attachments: HIVE-2198.1.patch, HIVE-2198.patch
>
>
> org.apache.hadoop.hive.service.ThriftHive.Client.clean() method is called for every session end in CLI mode for the cleanup but in HiveServer mode this is not called.
> So this can be integrate with the HiveConnection.close()

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2198) While using Hive in server mode, HiveConnection.close() is not cleaning up server side resources

Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063920#comment-13063920 ] 

Chinna Rao Lalam commented on HIVE-2198:
----------------------------------------

Opened Review Board request

https://reviews.apache.org/r/1089/


> While using Hive in server mode, HiveConnection.close() is not cleaning up server side resources
> ------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2198
>                 URL: https://issues.apache.org/jira/browse/HIVE-2198
>             Project: Hive
>          Issue Type: Bug
>          Components: Server Infrastructure
>    Affects Versions: 0.5.0, 0.8.0
>         Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
>            Reporter: Chinna Rao Lalam
>            Assignee: Chinna Rao Lalam
>         Attachments: HIVE-2198.patch
>
>
> org.apache.hadoop.hive.service.ThriftHive.Client.clean() method is called for every session end in CLI mode for the cleanup but in HiveServer mode this is not called.
> So this can be integrate with the HiveConnection.close()

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2198) While using Hive in server mode, HiveConnection.close() is not cleaning up server side resources

Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chinna Rao Lalam updated HIVE-2198:
-----------------------------------

    Attachment: HIVE-2198.1.patch

> While using Hive in server mode, HiveConnection.close() is not cleaning up server side resources
> ------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2198
>                 URL: https://issues.apache.org/jira/browse/HIVE-2198
>             Project: Hive
>          Issue Type: Bug
>          Components: Server Infrastructure
>    Affects Versions: 0.5.0, 0.8.0
>         Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
>            Reporter: Chinna Rao Lalam
>            Assignee: Chinna Rao Lalam
>         Attachments: HIVE-2198.1.patch, HIVE-2198.patch
>
>
> org.apache.hadoop.hive.service.ThriftHive.Client.clean() method is called for every session end in CLI mode for the cleanup but in HiveServer mode this is not called.
> So this can be integrate with the HiveConnection.close()

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2198) While using Hive in server mode, HiveConnection.close() is not cleaning up server side resources

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Sichi updated HIVE-2198:
-----------------------------

    Status: Open  (was: Patch Available)

Changes look fine, but could you fix the indentation?

> While using Hive in server mode, HiveConnection.close() is not cleaning up server side resources
> ------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2198
>                 URL: https://issues.apache.org/jira/browse/HIVE-2198
>             Project: Hive
>          Issue Type: Bug
>          Components: Server Infrastructure
>    Affects Versions: 0.5.0, 0.8.0
>         Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
>            Reporter: Chinna Rao Lalam
>            Assignee: Chinna Rao Lalam
>         Attachments: HIVE-2198.patch
>
>
> org.apache.hadoop.hive.service.ThriftHive.Client.clean() method is called for every session end in CLI mode for the cleanup but in HiveServer mode this is not called.
> So this can be integrate with the HiveConnection.close()

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2198) While using Hive in server mode, HiveConnection.close() is not cleaning up server side resources

Posted by "Chinna Rao Lalam (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chinna Rao Lalam updated HIVE-2198:
-----------------------------------

    Status: Patch Available  (was: Open)

> While using Hive in server mode, HiveConnection.close() is not cleaning up server side resources
> ------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2198
>                 URL: https://issues.apache.org/jira/browse/HIVE-2198
>             Project: Hive
>          Issue Type: Bug
>          Components: Server Infrastructure
>    Affects Versions: 0.5.0, 0.8.0
>         Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
>            Reporter: Chinna Rao Lalam
>            Assignee: Chinna Rao Lalam
>         Attachments: HIVE-2198.patch
>
>
> org.apache.hadoop.hive.service.ThriftHive.Client.clean() method is called for every session end in CLI mode for the cleanup but in HiveServer mode this is not called.
> So this can be integrate with the HiveConnection.close()

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira